feat: tag queue new-feature-badge variation as Amplitude user property#14269
Merged
dylanjeffers merged 1 commit intomainfrom May 7, 2026
Merged
feat: tag queue new-feature-badge variation as Amplitude user property#14269dylanjeffers merged 1 commit intomainfrom
dylanjeffers merged 1 commit intomainfrom
Conversation
Dispatches an IDENTIFY action once when the queue_new_feature_badge
feature flag has loaded, with the variation ('on'/'off') as a user
property. Lets us slice Amplitude charts by variation for the A/B test.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets an Amplitude user property
queue_new_feature_badge='on' | 'off'so the A/B test for the play-queue "New" badge (#14254) can be sliced in Amplitude. Currently nothing surfaces the variation to Amplitude, so charts can't filter by treatment vs. control.queue_new_feature_badge?: 'on' | 'off'toIdentifyTraits.useQueueNewFeatureBadge, dispatchesANALYTICS/IDENTIFYonce when the feature flag has loaded, with the variation as a trait. The existing analytics saga forwards it to both web and mobile Amplitude SDKs as a user property viaIdentify.set(...).useRefguard so it dispatches at most once per mount; AmplitudeIdentify.setis idempotent so re-fires across mounts are harmless.Optimizely setup (separate, not in this PR)
Create a flag named
queue_new_feature_badge(lowercase, exact) with a Targeted Delivery rule at 50% included → variationon. The flag default isfalse(feature-flags.ts), so until the rule is on, all users get tagged'off'.Test plan
Identifycall fires once withqueue_new_feature_badge: 'on'(Amplitude network panel / Redux DevToolsANALYTICS/IDENTIFYaction).'off'.QueueButton) and mobile (ActionsBar) — both consume the hook.🤖 Generated with Claude Code