ci(mobile): symlink react-native CLI for CodePush OTA bundling#14387
Merged
Conversation
After #14365 the react-native dep is hoisted to the monorepo root node_modules/, so packages/mobile/node_modules/.bin/react-native no longer exists. @bravemobile/react-native-code-push@12.3.2 hardcodes the relative path `node_modules/.bin/react-native` (cwd = packages/mobile) when running `react-native bundle`, which fails with exit 127. Symlink the hoisted bin into packages/mobile/node_modules/.bin in both OTA jobs before invoking code-push. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_modules/.bin/react-native: not found(exit 127). Example: run 26308703765.react-native(and the bin from@react-native-community/cli) hoists to the monorepo rootnode_modules/, sopackages/mobile/node_modules/.bin/react-nativeno longer exists.@bravemobile/react-native-code-push@12.3.2hardcodes the relative pathnode_modules/.bin/react-native(cwd ispackages/mobile) when invokingreact-native bundle, so the lookup fails.npx code-push releasein bothmobile-ota-releaseandmobile-ota-release-productionthat pointspackages/mobile/node_modules/.bin/react-nativeat the hoisted root binary.Test plan
mainsucceeds (or workflow_dispatch w/rcchannel).mainsucceeds.🤖 Generated with Claude Code