chore(mobile): bump versions for release + restore Node in Android CI#14389
Merged
Conversation
Two changes needed to actually publish a release on main:
1. Version bump for the binary build jobs to fire again. The version-
check job compares packages/mobile/package.json between HEAD and
HEAD^; once 1.5.180 landed, every subsequent commit reported
version_changed=false and skipped iOS/Android RC + Prod uploads.
Bump: package.json 1.5.180 -> 1.5.181, iOS Info.plist
CFBundleShortVersionString 1.1.193 -> 1.1.194, Android versionName
1.1.529 -> 1.1.530.
2. Android RC + Android Production jobs fail with EBADENGINE
("Required: node>=24.10.0, Actual: v22.22.3") during npm ci. Their
"Free disk space" step does `sudo rm -rf "$AGENT_TOOLSDIRECTORY"`,
which also wipes the Node 24 install placed by the earlier
setup-node step. Java is intentionally re-set-up after cleanup;
Node was not. Add a matching "Setup Node.js (after disk cleanup)"
step (plus the npm 11 upgrade) so npm ci picks up Node 24 again.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes needed to actually publish a release on main:
Version bump for the binary build jobs to fire again. The
mobile-version-checkjob comparespackages/mobile/package.jsonversionbetweenHEADandHEAD^. Once 1.5.180 landed (PR chore(mobile): resolve react-native to 0.79.5 in lockfile + pods #14365 / commit 51cf0b2eb5), every subsequent commit reportedversion_changed=false, so the iOS RC, Android RC, iOS Production, and Android Production jobs all got skipped. Bumps:packages/mobile/package.json:1.5.180→1.5.181packages/mobile/ios/AudiusReactNative/Info.plistCFBundleShortVersionString:1.1.193→1.1.194packages/mobile/android/app/build.gradleversionName:1.1.529→1.1.530Android RC + Android Production CI no longer falls back to Node 22. In run 26246576840, both Android jobs failed
npm ciwith:The job order is
Setup Node.js → Setup Android SDK → Free disk space → Setup Java (after disk cleanup) → … → Install dependencies. The "Free disk space" step doessudo rm -rf "$AGENT_TOOLSDIRECTORY", which is whereactions/setup-node@v4placed Node 24 — so by the timenpm ciruns, only the runner's system Node 22 is on PATH. Java is intentionally re-set-up after cleanup; Node was not. This PR adds a matchingSetup Node.js (after disk cleanup)step (plus the npm 11 upgrade) in both Android jobs.The iOS failures in that run were caused by an unrelated duplicate
makeimport inContestScreen.tsx, which has already been fixed on main by 802487bb3a.Test plan
🤖 Generated with Claude Code