Fix artist spotlight card name truncation#14400
Merged
Merged
Conversation
Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
|
Contributor
🌐 Web preview readyPreview URL: https://audius-web-preview-pr-14400.audius.workers.dev Unique preview for this PR (deployed from this branch). |
Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
Co-authored-by: Ray Jacobson <raymondjacobson@users.noreply.github.com>
UserCard now uses UserLink with `ellipses` + `popover` again instead of re-implementing the name+badge layout inline. The UserLink and UserBadges updates from this PR already make truncation work correctly through the standard component path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
The popover branch used `display: inline-flex` + `width: 100%` on the outer Flex container. That combination doesn't shrink children reliably — flex items kept their natural content width and the parent's overflow clipped the result instead of triggering ellipsis. Switch to `direction='row'` + `w='100%'` (plain block-level flex), and drop `display: inline-flex` on the ArtistPopover span in favor of `display: flex`. Also collapse the redundant inner `<Text ellipses>` wrapper when ellipses is already applied on the TextLink itself. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserLinknames shrink and ellipsize correctly inside card/popover flex layouts.Validation
npm run typecheck -w @audius/webnpm run lint -w @audius/web -- --quiet