Skip to content

fix(web): route contest notification inbox rows to Contest page #14402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanjeffers merged 1 commit into from
May 26, 2026
Merged

fix(web): route contest notification inbox rows to Contest page #14402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...ages/web/src/components/notification/Notification/ArtistRemixContestEndedNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@ import { useDispatch } from 'react-redux'
import { Link } from 'react-router'

import { push } from 'utils/navigation'
import { pickWinnersPage } from 'utils/route'
import { contestPage, pickWinnersPage } from 'utils/route'

import { NotificationBody } from './components/NotificationBody'
import { NotificationFooter } from './components/NotificationFooter'
import { NotificationHeader } from './components/NotificationHeader'
import { NotificationTile } from './components/NotificationTile'
import { NotificationTitle } from './components/NotificationTitle'
import { getEntityLink } from './utils'

const messages = {
title: 'Your Remix Contest Ended',
Expand Down Expand Up @@ -48,7 +47,7 @@ export const ArtistRemixContestEndedNotification = (

const handleClick = useCallback(() => {
if (entity) {
dispatch(push(getEntityLink(entity)))
dispatch(push(contestPage(entity.permalink)))
}
}, [entity, dispatch])

Expand Down
4 changes: 2 additions & 2 deletions ...web/src/components/notification/Notification/ArtistRemixContestEndingSoonNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ import { useDispatch } from 'react-redux'

import { TrackLink } from 'components/link'
import { push } from 'utils/navigation'
import { contestPage } from 'utils/route'

import { NotificationBody } from './components/NotificationBody'
import { NotificationFooter } from './components/NotificationFooter'
import { NotificationHeader } from './components/NotificationHeader'
import { NotificationTile } from './components/NotificationTile'
import { NotificationTitle } from './components/NotificationTitle'
import { getEntityLink } from './utils'

const messages = {
title: 'Remix Contest',
Expand All @@ -40,7 +40,7 @@ export const ArtistRemixContestEndingSoonNotification = (

const handleClick = useCallback(() => {
if (entity) {
dispatch(push(getEntityLink(entity)))
dispatch(push(contestPage(entity.permalink)))
}
}, [entity, dispatch])

Expand Down
4 changes: 2 additions & 2 deletions ...eb/src/components/notification/Notification/ArtistRemixContestSubmissionsNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ import { useDispatch } from 'react-redux'

import { TrackLink } from 'components/link'
import { push } from 'utils/navigation'
import { contestPage } from 'utils/route'

import { NotificationBody } from './components/NotificationBody'
import { NotificationFooter } from './components/NotificationFooter'
import { NotificationHeader } from './components/NotificationHeader'
import { NotificationTile } from './components/NotificationTile'
import { NotificationTitle } from './components/NotificationTitle'
import { getEntityLink } from './utils'

const messages = {
title: 'New Remix Submission!',
Expand All @@ -42,7 +42,7 @@ export const ArtistRemixContestSubmissionsNotification = ({

const handleClick = useCallback(() => {
if (entity) {
dispatch(push(getEntityLink(entity)))
dispatch(push(contestPage(entity.permalink)))
}
}, [entity, dispatch])

Expand Down
4 changes: 2 additions & 2 deletions packages/web/src/components/notification/Notification/FanRemixContestEndedNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { Flex, IconTrophy } from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { push } from 'utils/navigation'
import { contestPage } from 'utils/route'

import { NotificationBody } from './components/NotificationBody'
import { NotificationFooter } from './components/NotificationFooter'
Expand All @@ -17,7 +18,6 @@ import { NotificationTile } from './components/NotificationTile'
import { NotificationTitle } from './components/NotificationTitle'
import { TrackContent } from './components/TrackContent'
import { UserNameLink } from './components/UserNameLink'
import { getEntityLink } from './utils'

const messages = {
title: 'Remix Contest',
Expand All @@ -44,7 +44,7 @@ export const FanRemixContestEndedNotification = (

const handleClick = useCallback(() => {
if (entity) {
dispatch(push(getEntityLink(entity)))
dispatch(push(contestPage(entity.permalink)))
}
}, [entity, dispatch])

Expand Down
4 changes: 2 additions & 2 deletions ...es/web/src/components/notification/Notification/FanRemixContestEndingSoonNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { Flex, IconTrophy } from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { push } from 'utils/navigation'
import { contestPage } from 'utils/route'

import { NotificationBody } from './components/NotificationBody'
import { NotificationFooter } from './components/NotificationFooter'
Expand All @@ -17,7 +18,6 @@ import { NotificationTile } from './components/NotificationTile'
import { NotificationTitle } from './components/NotificationTitle'
import { TrackContent } from './components/TrackContent'
import { UserNameLink } from './components/UserNameLink'
import { getEntityLink } from './utils'

const messages = {
title: 'Remix Contest',
Expand All @@ -44,7 +44,7 @@ export const FanRemixContestEndingSoonNotification = (

const handleClick = useCallback(() => {
if (entity) {
dispatch(push(getEntityLink(entity)))
dispatch(push(contestPage(entity.permalink)))
}
}, [entity, dispatch])

Expand Down
4 changes: 2 additions & 2 deletions packages/web/src/components/notification/Notification/FanRemixContestStartedNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { useDispatch } from 'react-redux'

import { TrackLink } from 'components/link'
import { push } from 'utils/navigation'
import { contestPage } from 'utils/route'

import { NotificationBody } from './components/NotificationBody'
import { NotificationFooter } from './components/NotificationFooter'
Expand All @@ -18,7 +19,6 @@ import { NotificationTile } from './components/NotificationTile'
import { NotificationTitle } from './components/NotificationTitle'
import { TrackContent } from './components/TrackContent'
import { UserNameLink } from './components/UserNameLink'
import { getEntityLink } from './utils'

const messages = {
title: 'New Remix Contest',
Expand Down Expand Up @@ -46,7 +46,7 @@ export const FanRemixContestStartedNotification = (

const handleClick = useCallback(() => {
if (entity) {
dispatch(push(getEntityLink(entity)))
dispatch(push(contestPage(entity.permalink)))
}
}, [entity, dispatch])

Expand Down
4 changes: 2 additions & 2 deletions ...b/src/components/notification/Notification/FanRemixContestWinnersSelectedNotification.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { Flex, IconTrophy } from '@audius/harmony'
import { useDispatch } from 'react-redux'

import { push } from 'utils/navigation'
import { contestPage } from 'utils/route'

import { NotificationBody } from './components/NotificationBody'
import { NotificationFooter } from './components/NotificationFooter'
Expand All @@ -17,7 +18,6 @@ import { NotificationTile } from './components/NotificationTile'
import { NotificationTitle } from './components/NotificationTitle'
import { TrackContent } from './components/TrackContent'
import { UserNameLink } from './components/UserNameLink'
import { getEntityLink } from './utils'

const messages = {
title: 'Remix Contest',
Expand All @@ -43,7 +43,7 @@ export const FanRemixContestWinnersSelectedNotification = (

const handleClick = useCallback(() => {
if (entity) {
dispatch(push(getEntityLink(entity)))
dispatch(push(contestPage(entity.permalink)))
}
}, [entity, dispatch])

Expand Down
Loading