fix(types): preserve permalink on RemixContestEvent#14517
Merged
Conversation
OverrideProperties<Event, {eventData}> loses the optional permalink
property because type-fest's Merge/Simplify chain doesn't fully
distribute through the doubly-nested intersection that Event resolves to.
Intersect Pick<Event, 'permalink'> explicitly so the type survives and
ContestScreen can access contest.permalink without a TS2339 error.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
permalink was speculatively added to EventSDK and the common Event model but the API does not return it. Remove it from both the SDK type and the common model, revert the useRemixContest Pick<Event, 'permalink'> patch, and drop contest?.permalink from ContestScreen's useCallback dep array. Fixes TS2339 and the exhaustive-deps lint warning in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OverrideProperties<Event, {eventData}> loses the optional
permalinkproperty because type-fest's Merge/Simplify chain does not fully distribute through the doubly-nested intersection that Event resolves to. CI is failing with TS2339 onContestScreen.tsx:223.Fix: intersect
Pick<Event, 'permalink'>explicitly so the type survives and ContestScreen can accesscontest.permalinkwithout error.