Refresh balances when indexing Transfer instructions#2913
Merged
Conversation
rickyrombo
added
the
discovery-node
jowlee
approved these changes
Apr 13, 2022
cheran-senthil
pushed a commit
that referenced
this pull request
Apr 13, 2022
* Index claimable token transfer instructions and refresh balances * Remove 'Claim' since we renamed to Transfer
raymondjacobson
added a commit
that referenced
this pull request
May 27, 2026
The S3 sync at android/fastlane/Fastfile lines 101-102 was introduced in #2913 (Mar 2023, "OTA Updates CI Flow") as the artifact-archive step that fed the original CodePush OTA backend. CodePush itself was removed in #11708 (May 2025, "Remove code-push") but this step was left orphaned. The current OTA pipeline (Mobile OTA Release jobs in mobile.yml) talks to a separate OTA backend at download.audius.co/ mobile-ota via `npx code-push release` from packages/mobile/ — it does not read from these S3 buckets. The buckets s3://audius-mobile{,-releasecandidate,-staging,-staging- releasecandidate} have already been turned down (run 26471836695 fails with NoSuchBucket), confirming no consumer remains. Remove the dead code instead of papering over with `|| true`: - android/fastlane/Fastfile: - drop `sudo pip install awscli` step - drop `aws s3 sync … s3://…/android --delete` step - drop the four `remoteDirectory = '…'` assignments (only used by the removed sync) - .github/workflows/mobile.yml: - drop `Configure AWS credentials` from `Android Release Candidate Build & Upload` and `Android Production Build & Upload` (only consumer was the now-removed sync). OTA jobs still configure their own AWS credentials. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
raymondjacobson
added a commit
that referenced
this pull request
May 27, 2026
…non-fatal (#14403) ## Summary Follow-ups from [run 26471836695](https://github.com/AudiusProject/apps/actions/runs/26471836695). The previous PR (#14397) worked end-to-end where it mattered — **Android gradle build went green in 8m 30s** (track-player 4.1.2 + hermesc fix) and iOS made it deep into archive. Two real blockers remain. ### 1. iOS — fmt 11.0.2 ignores \`-DFMT_USE_CONSTEVAL=0\` #14397 added \`FMT_USE_CONSTEVAL=0\` to the \`fmt\` target's \`GCC_PREPROCESSOR_DEFINITIONS\`. It didn't take effect because fmt 11.0.2 does **not** guard its detection block with \`#ifndef FMT_USE_CONSTEVAL\`: \`\`\`cpp // include/fmt/base.h — fmt 11.0.2 // Detect consteval, ... #if !defined(__cpp_lib_is_constant_evaluated) # define FMT_USE_CONSTEVAL 0 #elif FMT_CPLUSPLUS < 201709L # define FMT_USE_CONSTEVAL 0 ... (several branches, none under #ifndef FMT_USE_CONSTEVAL) #elif defined(__cpp_consteval) # define FMT_USE_CONSTEVAL 1 \`\`\` The elif chain unconditionally \`#define\`s the macro, clobbering my \`-D\`. fmt 11.2.0+ adds the missing \`#ifndef\` guard (fmtlib/fmt#4477); RN \`0.83-stable\` got the fmt 12.1.0 backport in facebook/react-native#56225 — but **no equivalent backport exists for 0.79-stable yet**. Switch to patching the source. The detection chain already has an Apple-specific carve-out: \`\`\`cpp #elif defined(__apple_build_version__) && __apple_build_version__ < 14000029L # define FMT_USE_CONSTEVAL 0 // consteval is broken in Apple clang < 14. \`\`\` Drop the \`< 14000029L\` clause via a Podfile post_install \`gsub\` so consteval is disabled for **all** Apple Clang builds, including Xcode 26's Apple Clang 17. fmt falls back to \`constexpr\` — the same code path that worked pre-Xcode-14. ### 2. Android — orphaned CodePush-era S3 sync, removed Android RC + Prod gradle builds succeeded. Both then failed at the post-build artifact archive in \`Fastfile:102\`: \`\`\` sh("aws s3 sync packages/mobile/android/app/build/outputs s3://audius-mobile-releasecandidate/android --delete") fatal error: NoSuchBucket — The specified bucket does not exist \`\`\` History trace: - **[#2913](#2913 (Mar 2023, "OTA Updates CI Flow") introduced this sync alongside \`codepushDeployment = …\` variables. It uploaded \`app/build/outputs/\` to per-channel S3 buckets (\`audius-mobile\`, \`audius-mobile-releasecandidate\`, \`audius-mobile-staging-releasecandidate\`, \`audius-mobile-staging\`) so the **original CodePush OTA service** could pull updates. - **[#11708](#11708 (May 2025, "Remove code-push") deleted CodePush itself but **left this S3 sync orphaned** in the Fastfile. - The current OTA pipeline (\`Mobile OTA Release\` jobs in \`mobile.yml\`) talks to a separate backend at \`download.audius.co/mobile-ota\` via \`npx code-push release\` from \`packages/mobile/\` — it does not read from these S3 buckets. - The buckets themselves have been turned down (returning \`NoSuchBucket\`), confirming no consumer remains. Remove the dead code: - \`packages/mobile/android/fastlane/Fastfile\`: drop the \`sudo pip install awscli\` step, the \`aws s3 sync\` step, and the four \`remoteDirectory = '…'\` assignments that only fed it. - \`.github/workflows/mobile.yml\`: drop \`Configure AWS credentials\` from \`Android Release Candidate Build & Upload\` and \`Android Production Build & Upload\` — its only consumer was the removed sync. The OTA jobs still configure their own AWS credentials. ### 3. Re-trigger the release flow - \`packages/mobile/package.json\`: \`1.5.184\` → \`1.5.185\` - iOS \`Info.plist\` \`CFBundleShortVersionString\`: \`1.1.197\` → \`1.1.198\` - Android \`versionName\`: \`1.1.533\` → \`1.1.534\` ## Test plan - [ ] Merge → version-check fires all 4 binary jobs - [ ] iOS RC + Prod compile \`fmt\` cleanly under Xcode 26 (look for "Patched Pods/fmt/include/fmt/base.h" in pod-install logs) and reach \`pilot\` - [ ] Android RC + Prod reach \`upload_to_play_store\` directly after gradle build (no AWS / S3 step in between) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refresh user balances on a user bank <=> user bank transfer
Tests
Tested locally using the claimable tokens CLI
How will this change be monitored? Are there sufficient logs?
N/A