[PAY-2019][PAY-2080][PAY-2056] Fix miscellaneous USDC upload validation bugs #6431

sddioulde · 2023-10-23T22:12:52Z

Description

So, lots of important bugs fixed in this PR:

access and sale menu selection saved on mobile
usdc purchase validation on mobile and web
remix/access settings fix based on selection (gated tracks can't be remixes)
editing gated tracks on web and mobile
[PAY-2037] Improve web usdc purchases validation -> [PAY-2037] Improve web usdc purchases validation #6441 was merged into this PR.

Worth calling out is that on web there is now an outer premium conditions variable (representing the saved premium conditions that is to be submitted) and a temporary inner premium conditions which has the last selected values for all the access options by the user. This allows us to go back and forth between the options seamlessly, and only extract the correct one when the user saves the changes. Prior to this, we had a somewhat gnarly onChange function coupled with other logic that was harder to understand.

There is a new hook called useAccessAndRemixSettings which determines what selections options are available for access & sale and remix. This is used by both web and mobile to simplify their previous logics.

There is still room for improvement and more consolidation around this work, e.g. ideally web and mobile would share the same (further simplified) validation schema logic.

Note: yup has been removed from the modules. Only the mobile upload was using it, while web (and some of our other libraries like libs/sdk) use zod. I've made the change so mobile uses zod now too.

PR kind of large but partly due to removal of old unused files, changes in lock file, and it also includes Ray's other work above. But hopefully not too bad to review. Please lmk otherwise.

How Has This Been Tested?

web and native mobile ios. vs stage

mobile.usdc.track.upload.mov

web.usdc.track.upload.mov

packages/mobile/src/screens/edit-track-screen/fields/AccessAndSaleField/AccessAndSaleField.tsx

audius-infra · 2023-10-23T22:14:31Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2023-10-24T15:56:45Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

Co-authored-by: Michelle Brier <michelle.brier4@gmail.com> Co-authored-by: Dylan Jeffers <dylan@audius.co>

socket-security · 2023-10-27T04:23:38Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: yup@0.32.11, yup@1.2.0

audius-infra · 2023-10-27T04:25:26Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2023-10-27T15:58:18Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2023-10-27T16:20:26Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2023-10-27T16:26:29Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2023-10-27T16:39:00Z

Preview this change https://demo.audius.co/sd-usdc-remix-stem-mobile

raymondjacobson · 2023-10-27T19:40:25Z

The videos are so useful. thanks a lot for adding.

* did we lose padding here b/w the sections?

I think validation on preview is incorrect. that field is not required (or at least it wasn't before) and should default to 0 if we click submit

raymondjacobson

it's a lot of code, and I'm not the best to review it, but it all seems reasonable to me other than my other comment!

packages/mobile/src/screens/edit-track-screen/EditTrackScreen.tsx

sddioulde · 2023-10-28T04:38:17Z

The videos are so useful. thanks a lot for adding.

* did we lose padding here b/w the sections?

I think validation on preview is incorrect. that field is not required (or at least it wasn't before) and should default to 0 if we click submit

seems like we did lose the padding compared to figma, but that's on main already. will fix here
edit: fixed

audius-infra · 2023-10-28T05:47:35Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2023-10-28T05:55:45Z

Preview this change https://demo.audius.co/sd-usdc-remix-stem-mobile

dylanjeffers

massive lift! as discussed a scary change before the launch, so lets be sure to test thoroughly on stage + release-candidate

packages/common/src/hooks/useAccessAndRemixSettings.ts

packages/mobile/src/screens/edit-track-screen/EditTrackScreen.tsx

packages/mobile/src/screens/edit-track-screen/screens/AccessAndSaleScreen.tsx

audius-infra · 2023-10-30T15:06:09Z

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

audius-infra · 2023-10-30T15:14:58Z

Preview this change https://demo.audius.co/sd-usdc-remix-stem-mobile

…on bugs (#6431) Co-authored-by: Saliou Diallo <saliou@audius.co> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: Michelle Brier <michelle.brier4@gmail.com> Co-authored-by: Dylan Jeffers <dylan@audius.co>

[f630ef2] [C-3313 C-3178] Add typography docs, Update Text (#6580) Dylan Jeffers [63c6fdc] [C-3177] Add shadow foundations doc (#6582) Dylan Jeffers [94b82cd] [C-3179] Add corner-radius foundations doc (#6583) Dylan Jeffers [b8d3a0f] [C-3180] Add spacing fondations doc (#6584) Dylan Jeffers [f494196] Add PasswordInput and HarmonyPasswordField C-3298 (#6578) nicoback2 [69f6e49] [Sign up] Put password and email pages into PageWithAudiusValues, create generic LeftContentContainer, add back button (#6566) nicoback2 [563dc0b] Update Paper default background (#6581) Dylan Jeffers [50ff676] [C-3151 C-3314] Add color foundation docs (#6573) Dylan Jeffers [0c7593f] [C-3258] Add Harmony Paper component and docs (#6556) Andrew Mendelsohn [81f0e8c] [PROTO-1386] Fix multiple sla-auditors in health check (#6557) Theo Ilie [9991e7c] [PAY-2122] Gate embeds for premium content (#6577) Raymond Jacobson [d23f244] [C-3219] Fix suggested follow popup (web) (#6529) Andrew Mendelsohn [95b8948] [PAY-2121] Don't skip previews in lineups (#6575) Reed [ee7528a] Bump version to 0.5.9 audius-infra [eac762b] [PAY-1976] Use receiver root wallet instead of ATA (#6574) Saliou Diallo [7b95045] Fix AudioPlayer missing src bug (#6572) Reed [613b7c8] [PROTO-1393] Fix mediorum using dev build without git SHA (#6571) Theo Ilie [051c20c] [C-3311] Fix validation icons in sign-in (#6570) Dylan Jeffers [0a83c34] [C-3210] Update a few internal harmony components and SelectablePill to use emotion (#6569) Kyle Shanks [65492a2] Lockfile update for pinning react-qrcode (#6568) Randy Schott [95a0051] Fix desktop deploy (#6535) Raymond Jacobson [c30dfb0] Fix balance formatting for usdc withdrawal events (#6565) Randy Schott [6cb2a37] Bump version to 0.5.8 audius-infra [d6b5fee] [C-3307] Fix track count check for collections sagas (#6553) Kyle Shanks [05a996f] Fix zindex of 10000s modals (#6563) Raymond Jacobson [8c48a95] Fix locked-status-badge text color (#6562) Dylan Jeffers [da10685] Fix USDC Manual Transfer Drawer layering (#6561) Marcus Pasell [91440d9] Bump to version 1.5.49 (#6560) Raymond Jacobson [bbadcdf] Update the drawer fix to not render on start (#6558) Marcus Pasell [c6fed0a] Fix lint (#6559) Raymond Jacobson [453201e] [PAY-2120] Add user dashboard (#6547) Raymond Jacobson [1bdb0c7] [C-3302] Migrate Icon to emotion (#6555) Dylan Jeffers [f4e89ab] [C-3303] Add harmony-theme-provider to web (#6554) Dylan Jeffers [eaba2e6] [C-3300 C-3301] Improve organization, use emotion in storybook (#6532) Dylan Jeffers [aa54213] Fix challenge new pill on android (#6552) Reed [6617985] [C-3308] Enable common tests (#6549) Dylan Jeffers [c1fd487] [PAY-2112] Don't attempt to use balance if total amount due drops below minimum (#6550) Randy Schott [d5c964b] [PAY-2031][PAY-2081] Fix coming soon message and reward padding (#6551) Saliou Diallo [f798b1e] PAY-2119: Fix Stripe Drawer zIndex on Android (#6546) Marcus Pasell [71e63ac] [PAY-2114] Show country is not supported message for purchases (#6542) Reed [f8d5ec5] [PAY-2116][PAY-2117] Re-enable form elements on USDC purchase error (#6548) Saliou Diallo [c7d458b] [C-3304] Update Button styles to work on desktop and older chrome versions (#6544) Kyle Shanks [ccfa0da] Fixes lint and typecheck (#6545) Dylan Jeffers [fb1b48c] [PAY-2109][PAY-2113] Miscellaneous gated track fixes (#6543) Saliou Diallo [f6dab03] Add end-of-lineup notice to premium tracks lineup (#6541) Dylan Jeffers [a514d74] Add teamId to mac dist notarize (#6534) Dylan Jeffers [af90f1d] [PAY-2115] Remove favorite btn when not purchased (#6540) Raymond Jacobson [039fad9] Fix manual transfer on android (#6539) Reed [65345f3] Fix desktop commands (#6538) Sebastian Klingler [1660bbc] Fix USDC manual transfer icon color (#6537) Reed [0b946f6] Bump version to 0.5.7 audius-infra [0b348d8] Enable scroll on StripeOnrampEmbed (#6536) Dylan Jeffers [9876a51] [PAY-2094] Update TOS (#6531) Raymond Jacobson [baa9363] [PAY-1880] Re-enable email summary notifs for purchases (#6475) Raymond Jacobson [aa0bfde] [C-3286] Finalize harmony button docs (#6528) Dylan Jeffers [fc9f4f8] Hotfix Content Node view width and lint for CI (#6530) Theo Ilie [1f65f39] [PAY-2086] Update TOS banner (#6527) Raymond Jacobson [670016a] [C-3227] Add emotion and theme to web and mobile (#6518) Dylan Jeffers [740b6e0] [PAY-2070] Fix dashboard filter (#6526) Raymond Jacobson [980f937] Bump mobile versions (#6524) Raymond Jacobson [adcebb7] Remove circular dep (#6525) Marcus Pasell [7fdc652] Fix margin (#6523) Saliou Diallo [a695fa5] Buy Crypto via SOL Fixes (#6517) Marcus Pasell [6a9f558] Various small USDC UI fixes (#6522) Reed [cf6e69c] Fix protocol dashboard bugs (#6521) Theo Ilie [5ea43b8] [PAY-2102] Fix locked content modal not opening regression bug (#6516) Saliou Diallo [825d7d2] Uncomment lines to apply v2 landing page (#6520) Saliou Diallo [2ae80e7] [PAY-2095] Analytics for USDC manual transfer (#6519) Reed [55719e3] [PAY-2105]Add opt-in tracking for modal open/close events (#6514) Randy Schott [50882b9] Add per service charts to protocol-dashboard (#6423) Michelle Brier [cd388c1] [PAY-2101] Cancel balance polling on purchase start (#6515) Reed [50e311f] Fix manual transfer UI on mobile web (#6512) Reed [5fc93aa] [PAY-2100] Hide manual transfer UI while purchase in progress (#6511) Reed [2956d58] Implement create password page - web C-3262 (#6443) nicoback2 [2ebd87c] [PAY-2093] USDC manual transfer web UI (#6507) Reed [d259dae] Add redux persist to web; use for library categories C-3125 C-3220 (#6354) nicoback2 [5aa48d0] [PAY-1984] More landing page updates (#6508) Saliou Diallo [44235cf] Bump version to 0.5.6 audius-infra [7ffdeac] Bump mobile versions (#6509) Raymond Jacobson [35ab00d] Add retries to Buy Crypto via SOL flow (#6503) Marcus Pasell [7f90f8e] [C-3275] Welcome doc and Component doc template (#6499) Dylan Jeffers [e944fd7] Fix remix access bug (#6506) Saliou Diallo [51de866] [PAY-2088] Hide play counts on premium on mobile (#6505) Raymond Jacobson [97e4bc6] [PAY-2044] Add Stripe taking a while toast (#6492) Raymond Jacobson [979d3a9] Redirect root with hash routing (#6502) Theo Ilie [1eb740c] [PROTO-1373] Introduce arm machine type to ci runner bootstrap script (#6500) Danny [2ce4aad] [PAY-1987] Remove check for audio matching challenges in non-prod envs (#6501) Reed [3bea782] Buy Crypto via SOL (#6496) Marcus Pasell [db79330] [C-3284 C-3285] Improve harmony icons and build (#6495) Dylan Jeffers [09ddbda] [PAY-2017] Adds analytics for withdraw flow (#6497) Randy Schott [9c6fe35] [PROTO-1210]: better transcode failure handling. (#6498) Steve Perkins [471ccf7] [PAY-2019][PAY-2080][PAY-2056] Fix miscellaneous USDC upload validation bugs (#6431) Saliou Diallo [99b5cd1] Bump version to 0.5.5 audius-infra [24af5d5] [C-3277] Add harmony theming (#6483) Dylan Jeffers

pull-request-size bot added the size/L label Oct 23, 2023

sddioulde commented Oct 23, 2023

View reviewed changes

packages/mobile/src/screens/edit-track-screen/fields/AccessAndSaleField/AccessAndSaleField.tsx Show resolved Hide resolved

sddioulde force-pushed the sd-usdc-remix-stem-mobile branch from dedda60 to 7e86d74 Compare October 23, 2023 22:23

pull-request-size bot added size/XL and removed size/L labels Oct 24, 2023

raymondjacobson changed the title ~~[PAY-2019] WIP~~ [PAY-2019] Fix miscellaneous USDC upload validation bugs Oct 24, 2023

sddioulde force-pushed the sd-usdc-remix-stem-mobile branch from 8c91c5f to a869fe5 Compare October 24, 2023 16:13

pull-request-size bot added size/XXL and removed size/XL labels Oct 26, 2023

sddioulde force-pushed the sd-usdc-remix-stem-mobile branch 4 times, most recently from 76fd84f to 92afd36 Compare October 26, 2023 05:03

sddioulde changed the title ~~[PAY-2019] Fix miscellaneous USDC upload validation bugs~~ [PAY-2019][PAY-2080][PAY-2056] Fix miscellaneous USDC upload validation bugs Oct 26, 2023

sddioulde force-pushed the sd-usdc-remix-stem-mobile branch 3 times, most recently from ad13ab1 to 421c4c4 Compare October 26, 2023 16:05

Saliou Diallo and others added 11 commits October 26, 2023 23:46

Fix access and sale field labels and usdc purchase selection

e1b66be

Refactor access and remix settings

9c37d45

Fix collectible gated label bug on web

29eb45e

Remove unused

9c01607

Prevent going back on invalid access and sale screen form

ba86774

[PAY-2037] Improve web usdc purchases validation (#6441)

a75558f

Co-authored-by: Michelle Brier <michelle.brier4@gmail.com> Co-authored-by: Dylan Jeffers <dylan@audius.co>

Lint

94be6b4

Use previewStartSeconds

5a93d03

Fix remix settings callout text

daf9b05

Fix web upload and edit

ace06cb

Fix mobile upload and edit

0cac1a1

Fix track description mobile validation

e680a18

Rename

c7b6cfc

sddioulde requested review from dylanjeffers and schottra October 27, 2023 16:14

sddioulde assigned amendelsohn and raymondjacobson Oct 27, 2023

Remove unnecessary ts-ignore

73345eb

Lint common

b4caa61

raymondjacobson approved these changes Oct 27, 2023

View reviewed changes

packages/mobile/src/screens/edit-track-screen/EditTrackScreen.tsx Outdated Show resolved Hide resolved

Fix typo

d7f808e

Saliou Diallo added 2 commits October 28, 2023 00:43

Add preview field margin

e5dbc3c

Fix mobile usdc gated track preview default

728475a

dylanjeffers approved these changes Oct 30, 2023

View reviewed changes

Address PR comments

2b052ca

sddioulde merged commit 471ccf7 into main Oct 30, 2023

sddioulde deleted the sd-usdc-remix-stem-mobile branch October 30, 2023 15:27

[PAY-2019][PAY-2080][PAY-2056] Fix miscellaneous USDC upload validation bugs #6431

[PAY-2019][PAY-2080][PAY-2056] Fix miscellaneous USDC upload validation bugs #6431

Uh oh!

Conversation

sddioulde commented Oct 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

Uh oh!

audius-infra commented Oct 23, 2023

Uh oh!

audius-infra commented Oct 24, 2023

Uh oh!

socket-security bot commented Oct 27, 2023

Uh oh!

audius-infra commented Oct 27, 2023

Uh oh!

audius-infra commented Oct 27, 2023

Uh oh!

audius-infra commented Oct 27, 2023

Uh oh!

audius-infra commented Oct 27, 2023

Uh oh!

audius-infra commented Oct 27, 2023

Uh oh!

raymondjacobson commented Oct 27, 2023

Uh oh!

raymondjacobson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sddioulde commented Oct 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

audius-infra commented Oct 28, 2023

Uh oh!

audius-infra commented Oct 28, 2023

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

audius-infra commented Oct 30, 2023

Uh oh!

audius-infra commented Oct 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sddioulde commented Oct 23, 2023 •

edited

Loading

sddioulde commented Oct 28, 2023 •

edited

Loading