This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Client uses cids in requests to CN for images #3882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview this change https://demo.audius.co/mbrier/con-820/request-cids |
dylanjeffers
approved these changes
Aug 15, 2023
Contributor
dylanjeffers
left a comment
dylanjeffers
left a comment
There was a problem hiding this comment.
EXCELLENT work, this makes a ton of sense. main question is about missing sizes if that's something reasonable wed want to catch? Also looks like mobile init failed. lmk if you need help with that
Contributor
dylanjeffers
left a comment
dylanjeffers
left a comment
There was a problem hiding this comment.
Also another thought, did you test photo updates? i think for instance when a user updates their cover_photo, we use the "OVERRIDE" section of _cover_art_sizes to use a local image. it appears with this new setup that wont be respected?
Collaborator
|
Preview this change https://demo.audius.co/mbrier/con-820/request-cids |
1 similar comment
Collaborator
|
Preview this change https://demo.audius.co/mbrier/con-820/request-cids |
michellebrier
force-pushed
the
mbrier/con-820/request-cids
branch
from
077b5f1 to
b90a12a
Compare
Collaborator
|
Preview this change https://demo.audius.co/mbrier/con-820/request-cids |
michellebrier
force-pushed
the
mbrier/con-820/request-cids
branch
from
4bb017f to
9fdb2e7
Compare
Collaborator
|
Preview this change https://demo.audius.co/mbrier/con-820/request-cids |
Collaborator
|
Preview this change https://demo.audius.co/mbrier/con-820/request-cids |
Collaborator
|
Preview this change https://demo.audius.co/mbrier/con-820/request-cids |
Collaborator
|
Preview this change https://demo.audius.co/mbrier/con-820/request-cids |
michellebrier
added a commit
that referenced
this pull request
Aug 23, 2023
schottra
added a commit
that referenced
this pull request
Aug 25, 2023
* origin/main: Add lint check for console.log and remove some bad ones (#3930) [C-2968] Fix private collection action buttons (#3937) Fix canonical url consistency (#3938) [C-2689] Add upload confirmation modal (#3934) [C-2966] Make sure that collection description limits are set to 1000 (#3935) Move sitemap hostname back to audius.co (#3931) Client uses cids in requests to CN for images (#3882) Add library albums and playlists audius-query hook + migrate collection reformat util; bump SDK PAY-1679 (#3864) [C-2982] Fix seo based on ahref recommendations (#3929) Migrate withdraw USDC saga to web common (#3928) USDC Withdrawal saga scaffolding (#3926) Fix useAllPaginated query C-2980 (#3924) Fix infinite scrolling cards C-2979 (#3923) [PAY-1632] Clean up and improve performance of music confetti (#3921) Revert "Update twitter icon on mobile (#3880)" (#3925)
audius-infra
pushed a commit
that referenced
this pull request
Aug 26, 2023
[b39cb5d] [PAY-1733] Remove Gated Prompt Modal (#3948) Marcus Pasell [a522294] [PAY-1748][PAY-1731][PAY-1729][PAY-1730] DMs link fixes (#3946) Marcus Pasell [adea357] quick linting fix (#3945) Kyle Shanks [a0ff27c] Add embed cloudflare deployment and CI (#3940) Raymond Jacobson [337f80f] [PAY-1727] USDC Withdrawals saga pt. 1 (#3932) Reed [5bf820c] [C-2956] Add new Access & Sale modal to legacy upload form (#3900) Andrew Mendelsohn [5258675] [C-2986] Upload flow qa round 1 (#3941) Kyle Shanks [dd30c09] Use does_current_user_subscribe API field (#3943) Michelle Brier [778a518] [C-2987] Add UserGeneratedText (#3942) Dylan Jeffers [bb9e0cf] Update pull_request_template.md (#3939) Raymond Jacobson [930dd1a] [C-2977] Fix collection page seo (#3936) Dylan Jeffers [1e50b85] Update README.md (#3911) sabrina-kiam [687fd28] Add lint check for console.log and remove some bad ones (#3930) Raymond Jacobson [9f67e7b] [C-2968] Fix private collection action buttons (#3937) Dylan Jeffers [7ab7a38] Fix canonical url consistency (#3938) Dylan Jeffers [b1fbef8] [C-2689] Add upload confirmation modal (#3934) Kyle Shanks [eb41fd3] [C-2966] Make sure that collection description limits are set to 1000 (#3935) Kyle Shanks [6258484] Move sitemap hostname back to audius.co (#3931) Raymond Jacobson [1e0c335] Client uses cids in requests to CN for images (#3882) Michelle Brier [7974acc] Add library albums and playlists audius-query hook + migrate collection reformat util; bump SDK PAY-1679 (#3864) nicoback2 [7cba35b] [C-2982] Fix seo based on ahref recommendations (#3929) Dylan Jeffers [05744b3] Migrate withdraw USDC saga to web common (#3928) Reed [5d01710] USDC Withdrawal saga scaffolding (#3926) Reed [4e0c480] Fix useAllPaginated query C-2980 (#3924) nicoback2 [21eb35c] Fix infinite scrolling cards C-2979 (#3923) nicoback2 [0025261] [PAY-1632] Clean up and improve performance of music confetti (#3921) Raymond Jacobson [7ed2248] Revert "Update twitter icon on mobile (#3880)" (#3925) Reed [1091934] [PAY-1742] Remove useMetaMask on invalid account (#3920) Raymond Jacobson [6e303b1] [PAY-1741] Add routes for transactional pages (#3916) Randy Schott [74cdb3c] Remove ontouchstart from index.html (#3919) Raymond Jacobson [1a0332c] Improve lighthouse score (#3918) Raymond Jacobson [a63896f] [PAY-1706] Merge modalsWithState with modals in common store (#3908) Marcus Pasell [6a08944] [C-2976] Fix profile-page seo (#3912) Dylan Jeffers [2381d46] Fix account details css (#3917) Raymond Jacobson [8c24bdd] Fix mobile share of playlist permalink (#3913) sabrina-kiam [1e376fe] [C-2911] Update new select page of the upload flow (#3910) Kyle Shanks [bc0226f] Fix stripe modal opening behavior (#3914) Raymond Jacobson [a3219c3] [C-2975] Fix stale local data (#3915) Dylan Jeffers [748fdfd] PAY-1724 Add color specialGreen on mobile (#3909) Reed [5c59fe5] [PAY-1628] Navigate to track after purchase (#3904) Randy Schott
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per changes in this PR, when querying for an image variant from the client, use the variant's cid (ingested from
*_cidsfields in API user/track/playlist responses) to query CNs. So the query is${cid's preferred storage node}/content/${cid}rather than${non-specific storage node}/content/${upload id}/${size}. This reduces redirects and image latency.Dragons
How Has This Been Tested?
Tested against stage node with API changes, used network developer tools panel to verify that the image variant's cid was queried directly from its preferred node for v1 and v2 cids.
Also tested against node without the API changes to verify backwards compatibility.
How will this change be monitored?
Feature Flags