Cruz Mendez #33
Open
Cruz Mendez #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still having issues with terminal. missing link or bad syntax?
jw56578
reviewed
Oct 7, 2017
| var currentItem = theArray[i]; | ||
| fnc(currentItem); | ||
| var returnedItem = fnc(currentItem); | ||
| if (returnedItem = true) { |
Contributor
There was a problem hiding this comment.
double check you code here.
how do you compare things to true or false in an if statement
jw56578
reviewed
Oct 7, 2017
| var returnedItem = fnc(currentItem); | ||
| if (returnedItem) { | ||
| return returnedItem; | ||
| } else { |
Contributor
There was a problem hiding this comment.
in general, you don't ever want to have a else statement return in a loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homework 1