Fix keyboard navigation and form input label accessibility issues#275
Merged
wparad merged 20 commits intoAuthress-Engineering:release/2.2from May 13, 2025
Merged
Fix keyboard navigation and form input label accessibility issues#275wparad merged 20 commits intoAuthress-Engineering:release/2.2from
wparad merged 20 commits intoAuthress-Engineering:release/2.2from
Conversation
wparad
requested changes
May 12, 2025
Member
wparad
left a comment
wparad
left a comment
There was a problem hiding this comment.
Mostly good improvements. I do have a couple of a questions, and one thing that will need changing before merge (details in relevant comment).
Co-authored-by: Warren Parad <5056218+wparad@users.noreply.github.com> Signed-off-by: Audrey Hamelers <1749394+ahamelers@users.noreply.github.com>
wparad
reviewed
May 13, 2025
wparad
approved these changes
May 13, 2025
Member
wparad
left a comment
wparad
left a comment
There was a problem hiding this comment.
I've made some small tweaks here based on my feedback and some slight style improvements. Feel free to take one last look and make sure that I didn't break anything that needed to be changed.
If nothing stands out, I'll merge it later today.
wparad
approved these changes
May 13, 2025
Member
|
Latest updates are fine, next time while entirely appreciated, let's try to avoid unnecessary scope creep (ie additional translations) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274