fix(schema): streamline schema change handling and enhance test coverage #3019
+2,100
−590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gezi-lzq
requested review from
1sonofqiu,
superhx and
woshigaopp
as code owners
Copilot finished reviewing on behalf of
Gezi-lzq
November 18, 2025 17:06
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances schema change handling in the Iceberg table management system by adding support for nested field changes within complex structures (structs, lists, and maps), while fixing critical issues in schema evolution logic.
Key Changes:
- Fixed MAKE_OPTIONAL schema change construction to pass
nullfor non-primitive types instead of incorrectly callingasPrimitiveType() - Added recursive processing for removed and changed fields in struct lists and struct maps
- Refactored field change detection logic into smaller, more focused methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IcebergTableManager.java | Core fix for MAKE_OPTIONAL handling; added methods isStructList, isStructMap, collectRemovedStructFields, and collectStructFieldChanges to recursively handle nested structures |
| IcebergWriterSchemaEvolutionTest.java | Comprehensive integration tests covering nested struct evolution, collection element changes, field additions/removals, and type promotions across multiple schema versions |
| IcebergTableManagerTest.java | Refactored unit tests with clearer naming and added tests for nested field operations, flush handling, and edge cases |
| IcebergSchemaChangeCollectorTest.java | New dedicated test suite for schema change detection logic covering all types of changes (additions, removals, promotions, optional conversions) at various nesting levels |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gezi-lzq
force-pushed
the
feat/schema-evolution
branch
from
5d89372 to
45bd7dd
Compare
Gezi-lzq
force-pushed
the
feat/schema-evolution
branch
from
45bd7dd to
ed96711
Compare
superhx
approved these changes
Nov 19, 2025
Gezi-lzq
added a commit
that referenced
this pull request
Nov 19, 2025
Gezi-lzq
added a commit
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced handling of nested fields: Added logic to recursively process removed and changed fields within structs, struct lists, and struct maps, ensuring schema changes are detected for all nested structures. [1] [2]
Corrected construction of
MAKE_OPTIONALschema changes: Now passesnullfor the type when marking a field as optional during soft removal, ensuring correct change representation.Refactored field change detection: Streamlined logic for adding columns, making fields optional, and promoting types.