Skip to content

feat(failover): don't failover the recovering node #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

feat(failover): don't failover the recovering node #3044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/main/java/kafka/automq/failover/NodeRuntimeMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

import java.util.Map;
import java.util.Objects;
import java.util.concurrent.TimeUnit;

/**
* NodeRuntimeMetadata is a runtime view of a node's metadata.
Expand All @@ -39,6 +40,7 @@ public final class NodeRuntimeMetadata {
* @see ClusterControlManager#getNextNodeId()
*/
private static final int MAX_CONTROLLER_ID = 1000 - 1;
private static final long DONT_FAILOVER_AFTER_NEW_EPOCH_MS = TimeUnit.MINUTES.toMillis(1);
private final int id;
private final long epoch;
private final String walConfigs;
Expand All @@ -60,7 +62,11 @@ public NodeRuntimeMetadata(int id, long epoch, String walConfigs, Map<String, St
}

public boolean shouldFailover() {
return isFenced() && hasOpeningStreams;
return isFenced() && hasOpeningStreams
// The node epoch is the start timestamp of node.
// We need to avoid failover just after node restart.
// The node may take some time to recover its data.
&& System.currentTimeMillis() - epoch > DONT_FAILOVER_AFTER_NEW_EPOCH_MS;
}

public boolean isFenced() {
Expand Down
Loading