refactor: extract Enhance with AI into shared components

[Shironex]

Summary

Refactor the "Enhance with AI" feature to eliminate code duplication and improve maintainability by extracting shared components following DRY principles and clean code guidelines.

Problem

The "Enhance with AI" feature and its history UI were duplicated across three dialogs:

• add-feature-dialog.tsx (~175 lines duplicated)
• edit-feature-dialog.tsx (~170 lines duplicated)

This violated the DRY principle and made maintenance difficult.

Solution

Created a dedicated shared/enhancement/ folder with reusable components:

New Components

1. enhancement-constants.ts

   • EnhancementMode type
   • ENHANCEMENT_MODE_LABELS constant
   • ENHANCEMENT_MODE_DESCRIPTIONS constant

2. enhance-with-ai.tsx

   • Reusable AI enhancement component
   • Manages state internally (isEnhancing, mode, collapsible)
   • Model override support
   • History tracking callback

3. enhancement-history-button.tsx

   • Generic history button component
   • Works with any history entry type
   • Popover UI with version browsing
   • Restore functionality
   • Source labels (Original/Enhanced/Edited)

Refactored Dialogs

• add-feature-dialog.tsx: -173 lines (-26%)
• edit-feature-dialog.tsx: -159 lines (-22%)

Additional Improvements

• Added history tracking to add-feature-dialog for consistency
• Fixed hardcoded enhancement labels in edit-feature-dialog
• Improved code organization following folder-pattern.md
• follow-up-dialog.tsx now also include the same feature as 2 other dialogs

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello @Shironex, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the 'Enhance with AI' feature, moving its implementation into a set of dedicated, reusable shared components. This change aims to drastically reduce code duplication across multiple dialogs, thereby enhancing the overall maintainability and consistency of the application's AI enhancement user interface. The update also standardizes and extends history tracking for AI-generated content across these dialogs.

Highlights

• Refactor "Enhance with AI" Feature: The core 'Enhance with AI' functionality and its associated history UI have been extracted into a new shared/enhancement/ folder to eliminate code duplication and improve maintainability.
• New Shared Components: Three new reusable components were created: enhance-with-ai.tsx for the AI enhancement UI, enhancement-history-button.tsx for generic history tracking and restoration, and enhancement-constants.ts for shared types and labels.
• Significant Code Reduction: The refactoring led to substantial line reductions in add-feature-dialog.tsx (-173 lines), edit-feature-dialog.tsx (-159 lines), and follow-up-dialog.tsx (-195 lines), totaling approximately 527 lines of removed duplication.
• Enhanced History Tracking: History tracking for AI-enhanced descriptions was added to add-feature-dialog for consistency, and the follow-up-dialog now also supports prompt history using the new shared components.
• Improved Consistency and Maintainability: By centralizing the logic, all dialogs now share the same AI enhancement and history UX, making future changes easier to implement and ensuring a consistent user experience.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This is an excellent refactoring that successfully extracts the 'Enhance with AI' functionality into shared, reusable components, significantly reducing code duplication and improving maintainability. The new components in shared/enhancement/ are well-designed and follow DRY principles. The overall code quality is high. I've identified a minor functional regression where thinkingLevel is no longer passed during enhancement, and a couple of opportunities to further improve the maintainability and performance of the new shared components. Overall, great work on cleaning up the codebase.

[Shironex]

/gemini please re-check after latest commits

[gemini-code-assist]

Code Review

This is an excellent refactoring that significantly improves code quality by extracting the 'Enhance with AI' functionality into reusable shared components. The changes effectively reduce code duplication in add-feature-dialog.tsx and edit-feature-dialog.tsx, and extend the functionality to follow-up-dialog.tsx, which is a great enhancement. The new shared components in shared/enhancement/ are well-structured and follow DRY principles.

My review includes a few suggestions to further improve consistency and maintainability, such as using the new shared types to eliminate remaining hardcoded values and ensuring new interfaces extend the shared base types. Overall, this is a very solid pull request.

[gemini-code-assist]

Code Review

This pull request does an excellent job of refactoring the 'Enhance with AI' feature into shared, reusable components, adhering to DRY principles and improving code maintainability. The new components are well-structured, and the feature has been consistently applied across the add-feature-dialog, edit-feature-dialog, and follow-up-dialog. My review includes a fix for a potential UI bug in the new history component and suggestions to enhance the new version history functionality to make it more robust and user-friendly by tracking manual edits.