-
Notifications
You must be signed in to change notification settings - Fork 393
feat(ui): Add project theme selection to context menu #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… refactoring Implement per-project theme override capability in the Discord-like layout: - Add theme submenu to project context menu with live preview - Reuse existing theme constants and useThemePreview hook from sidebar - Extract reusable ThemeButton and ThemeColumn components (DRY principle) - Replace magic z-index values with named constants Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Shironex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user interface by introducing per-project theme selection directly accessible from the project context menu. This allows for greater customization and visual distinction between projects. Alongside this new feature, the PR includes substantial refactoring, breaking down complex UI logic into smaller, reusable components and replacing magic numbers with named constants, which collectively improves the codebase's maintainability and scalability. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a great job of adding the project-specific theme selection feature. The code is well-refactored into reusable ThemeButton and ThemeColumn components, and the use of constants for z-index values is a good practice for maintainability. I have a few suggestions to enhance type safety and improve the robustness of the UI interactions for the new theme submenu.
Summary
Changes
ThemeButtonmemoized component for individual theme option buttonsThemeColumnmemoized component for dark/light theme sectionsZ_INDEXconstants object for context menu and submenu z-index valuesThemeOptioninterface for type safetyTest plan
Preview