Skip to content

Conversation

@Shironex
Copy link
Collaborator

@Shironex Shironex commented Jan 14, 2026

Summary

  • Add theme submenu to project context menu for per-project theme override capability
  • Refactor code following clean-code.md guidelines: extract reusable ThemeButton and ThemeColumn components (DRY principle)
  • Replace magic z-index values with named constants for better maintainability
  • Reuse existing theme constants and useThemePreview hook from sidebar

Changes

  • Extract ThemeButton memoized component for individual theme option buttons
  • Extract ThemeColumn memoized component for dark/light theme sections
  • Add Z_INDEX constants object for context menu and submenu z-index values
  • Add ThemeOption interface for type safety

Test plan

  • Open project context menu (right-click on project in sidebar)
  • Verify "Project Theme" submenu appears with chevron icon
  • Hover over theme options to see live preview
  • Select a theme to apply it to the project
  • Verify "Use Global" option correctly falls back to global theme
  • Test both dark and light theme columns display correctly

Preview

image

… refactoring

Implement per-project theme override capability in the Discord-like layout:
- Add theme submenu to project context menu with live preview
- Reuse existing theme constants and useThemePreview hook from sidebar
- Extract reusable ThemeButton and ThemeColumn components (DRY principle)
- Replace magic z-index values with named constants

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Shironex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user interface by introducing per-project theme selection directly accessible from the project context menu. This allows for greater customization and visual distinction between projects. Alongside this new feature, the PR includes substantial refactoring, breaking down complex UI logic into smaller, reusable components and replacing magic numbers with named constants, which collectively improves the codebase's maintainability and scalability.

Highlights

  • Per-Project Theme Selection: Introduced a new 'Project Theme' submenu within the project context menu, allowing users to override the global theme for individual projects.
  • UI Component Refactoring: Extracted ThemeButton and ThemeColumn into reusable, memoized components, adhering to DRY principles and improving code maintainability.
  • Z-Index Management: Replaced hardcoded z-index values with named Z_INDEX constants for better clarity and maintainability of UI layering.
  • Theme System Integration: Integrated existing theme constants (PROJECT_DARK_THEMES, PROJECT_LIGHT_THEMES) and the useThemePreview hook from the sidebar for consistent theme management and live preview functionality.
  • Type Safety Enhancement: Added a ThemeOption interface to improve type safety for theme-related data structures.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of adding the project-specific theme selection feature. The code is well-refactored into reusable ThemeButton and ThemeColumn components, and the use of constants for z-index values is a good practice for maintainability. I have a few suggestions to enhance type safety and improve the robustness of the UI interactions for the new theme submenu.

@Shironex Shironex self-assigned this Jan 14, 2026
@Shironex Shironex added Enhancement Improvements to existing functionality or UI. Ready-To-Merge A feature or bug has been improved/fixed and a final review is requested before merging. scope: ui UI/UX changes, layout, visual or interaction behavior. labels Jan 14, 2026
@Shironex Shironex merged commit df99950 into v0.11.0rc Jan 14, 2026
6 checks passed
@Shironex Shironex deleted the feature/v0.11.0rc-1768383713091-hnir branch January 14, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvements to existing functionality or UI. Ready-To-Merge A feature or bug has been improved/fixed and a final review is requested before merging. scope: ui UI/UX changes, layout, visual or interaction behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants