chore: remove ~13,000 lines of dead Electron code#53
Conversation
All business logic has been migrated to the REST API server. This removes obsolete Electron IPC handlers and services that are no longer used: - Deleted electron/services/ directory (18 files) - Deleted electron/agent-service.js - Deleted electron/auto-mode-service.js - Renamed main-simplified.js → main.js - Renamed preload-simplified.js → preload.js - Removed unused dependencies from package.json The Electron layer now only handles native OS features (10 IPC handlers): - File dialogs, shell operations, and app info 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @SuperComboGamer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a major architectural cleanup, removing a substantial amount of legacy Electron code that was no longer necessary due to the adoption of a REST API for core functionalities. The goal is to create a leaner, more maintainable Electron application that primarily serves as a wrapper for native OS interactions, while offloading complex business logic to a separate backend server. This change drastically reduces the Electron codebase footprint and simplifies its role within the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a major refactoring that removes approximately 13,000 lines of dead code from the Electron application by moving all business logic to a separate backend server. The Electron layer is now a thin client responsible only for native OS features like file dialogs and shell operations, communicating with the backend via a REST API. This is an excellent architectural improvement that simplifies the codebase and separates concerns effectively. My review found one minor regression where the handler for opening external links was removed, which I've suggested adding back.
Restores the handler that opens target="_blank" links in the default browser instead of trying to create a new Electron window. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…f his butt and switches the npm run stuff ;)
- Introduced a new DeleteSessionDialog component for confirming session deletions. - Integrated the delete session dialog into the SessionManager component, allowing users to delete sessions with a confirmation prompt. - Updated the UI to handle session deletion more intuitively, enhancing user experience. - Refactored existing delete confirmation logic to utilize the new DeleteConfirmDialog component for consistency across the application.
- Added 'data' directory to .gitignore to prevent tracking of generated files. - Ensured that sensitive environment files remain untracked by keeping '.env' entry.
…cody/automaker into cleanup/remove-dead-electron-code
Body:
Summary
electron/services/directory (18 files)electron/agent-service.jsandelectron/auto-mode-service.jsmain-simplified.js→main.jsandpreload-simplified.js→preload.jsWhat Remains
The Electron layer now only handles 10 IPC handlers for native OS features:
All business logic uses the REST API server.
Stats