Update LICENSE file to clarify Core Contributor status management and…#66
Update LICENSE file to clarify Core Contributor status management and…#66webdevcody merged 4 commits intomainfrom
Conversation
… commercial licensing terms - Added provisions for the revocation and reinstatement of Core Contributor status, requiring unanimous votes for both actions. - Introduced a new section outlining the process for discussing and issuing commercial licenses among Core Contributors. - Renumbered sections for clarity and consistency throughout the document.
Summary of ChangesHello @webdevcody, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the project's LICENSE file to formalize critical aspects of project governance and commercial engagement. It introduces clear guidelines for the management of Core Contributor status, including detailed procedures for both revocation and reinstatement, and establishes a structured process for issuing commercial licenses to external entities. These revisions aim to enhance the legal document's clarity, consistency, and comprehensiveness regarding project participation and commercial use. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
SHIP IT |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the license to introduce mechanisms for managing Core Contributor status and for issuing commercial licenses. The changes are well-structured, particularly the renumbering of sections for consistency. I've provided two suggestions to enhance the clarity and robustness of the new clauses. One is a minor formatting change to improve readability, and the other addresses a potential ambiguity between the static list of contributors and the new dynamic status management rules. Addressing this ambiguity is important to prevent future disputes.
| 4. CORE CONTRIBUTOR STATUS MANAGEMENT | ||
|
|
||
| a) Core Contributor status may be revoked indefinitely by the remaining Core Contributors if: | ||
|
|
||
| - A Core Contributor cannot be reached for a period of one (1) month through reasonable means of communication (including but not limited to email, Discord, GitHub, or other project communication channels) | ||
| - AND the Core Contributor has not contributed to the project during that one-month period | ||
| - For purposes of this section, "contributed" means at least one of the following activities: | ||
| - Discussing the Software through project communication channels | ||
| - Committing code changes to the project repository | ||
| - Submitting bug fixes or patches | ||
| - Participating in project-related discussions or decision-making | ||
|
|
||
| b) Revocation of Core Contributor status requires a unanimous vote by all other Core Contributors (excluding the Core Contributor whose status is being considered for revocation). | ||
|
|
||
| c) Upon revocation of Core Contributor status, the individual shall no longer be considered a Core Contributor and shall lose the rights granted under section 2(c) of this Agreement. However, any Contributions made prior to revocation shall remain subject to the terms of section 5 (CONTRIBUTIONS AND RIGHTS ASSIGNMENT). | ||
|
|
||
| d) A revoked Core Contributor may be reinstated to Core Contributor status with a unanimous vote by all current Core Contributors. Upon reinstatement, the individual shall regain all rights granted under section 2(c) of this Agreement. |
There was a problem hiding this comment.
This new section introduces dynamic management of Core Contributor status, but the definition of "Core Contributors" in Section 1 (line 29) is a static list of names. This creates a potential conflict:
- Section 4(c) states a revoked person "shall no longer be considered a Core Contributor," but their name would remain in the list in Section 1.
- Section 4(d) allows for reinstatement, but the process for updating the list isn't specified.
This ambiguity could lead to disputes over who holds Core Contributor rights.
To resolve this, consider adding a clause to clarify that the list in Section 1 is the canonical list and must be updated to reflect status changes. For example, you could add a new subsection e):
e) The list of individuals defined as "Core Contributors" in Section 1 shall be amended to reflect any revocation or reinstatement of status made under this section.This would ensure the license document remains the single source of truth for who the Core Contributors are.
LICENSE
Outdated
|
|
||
| - A Core Contributor cannot be reached for a period of one (1) month through reasonable means of communication (including but not limited to email, Discord, GitHub, or other project communication channels) | ||
| - AND the Core Contributor has not contributed to the project during that one-month period | ||
| - For purposes of this section, "contributed" means at least one of the following activities: |
There was a problem hiding this comment.
The way this definition of "contributed" is formatted makes it appear as a third, independent condition for revoking contributor status, which could be confusing. To improve clarity, I suggest nesting this definition under the condition it explains (line 73). This makes the logical flow clearer: there are two conditions, and the second one has a specific definition.
For purposes of this section, "contributed" means at least one of the following activities:
- Added a provision to update the list of Core Contributors to reflect any changes in status, ensuring clarity in the management of contributor roles.
- Clarified the conditions under which Core Contributor status may be revoked, ensuring that the definition of "contributed" is clearly stated in relation to communication and code contributions.
- Renamed section 8 to "LICENSE AMENDMENTS" and added provisions for unanimous agreement among Core Contributors for any amendments to the License Agreement. - Renumbered subsequent sections for improved clarity and organization.
|
2 participants
… commercial licensing terms