fix(docker): Add @playwright/test to server devDependencies#751
Open
JasonBroderick wants to merge 1 commit intoAutoMaker-Org:mainfrom
Open
fix(docker): Add @playwright/test to server devDependencies#751JasonBroderick wants to merge 1 commit intoAutoMaker-Org:mainfrom
JasonBroderick wants to merge 1 commit intoAutoMaker-Org:mainfrom
Conversation
📝 WalkthroughWalkthroughAdded Playwright test library version 1.57.0 as a dev dependency to the server application package configuration. This is a straightforward dependency addition with no functional code modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Summary of ChangesHello @JasonBroderick, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the application's AI capabilities by integrating GitHub Copilot and Google Gemini as new providers, alongside improvements to existing AI workflows. It introduces robust feature management tools, including export/import functionality and a comprehensive project overview API. Key infrastructure updates include a more resilient auto-mode graceful shutdown, a dedicated test runner service, and refined Docker configurations for smoother deployments. These changes aim to expand AI model choices, improve workflow flexibility, and enhance overall system stability and user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is titled as a small fix for a Docker dependency, but it actually contains a massive number of changes, including new features, major refactorings, and UI enhancements. This makes the review process very difficult and risky. In the future, please split such large changes into smaller, more focused pull requests. Additionally, this PR removes SECURITY_TODO.md and TODO.md files without any explanation or indication that the items within have been addressed. Removing a security to-do list, especially one containing critical vulnerabilities, without fixing them is a major concern.
Despite these process issues, the code changes themselves seem to be of high quality, introducing new providers like Gemini and Copilot, a test runner, project overview pages, and many UI/UX improvements. I've found one minor issue in the Dockerfile.
Dockerfile
Outdated
| COPY libs/model-resolver/package*.json ./libs/model-resolver/ | ||
| COPY libs/dependency-resolver/package*.json ./libs/dependency-resolver/ | ||
| COPY libs/git-utils/package*.json ./libs/git-utils/ | ||
| COPY libs/spec-parser/package*.json ./libs/spec-parser/ |
Contributor
There was a problem hiding this comment.
This line is a duplicate of line 28. Please remove it to avoid redundancy.
The Dockerfile's playwright install step requires playwright to be available in node_modules/.bin/, but playwright was only a UI dependency. This adds @playwright/test to server devDependencies so the Docker build can successfully run `./node_modules/.bin/playwright install chromium`. Fixes the "playwright: not found" error during Docker image build. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JasonBroderick
force-pushed
the
fix/docker-playwright-server-dependency
branch
from
6afde6f to
a3c9de1
Compare
Author
|
Lol - I think Gemini has lost it's mind 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue discovered while testing #745 (Pre-install Playwright Chromium browsers).
The Dockerfile's playwright install step fails because
@playwright/testis only in the UI's devDependencies, not the server's. When the Docker build runs:The
server-builderstage only installs server dependencies, soplaywrightisn't innode_modules/.bin/.Changes
@playwright/test: 1.57.0toapps/server/package.jsondevDependencies (matches UI version)Testing
docker compose build --no-cacheRelated
🤖 Generated with Claude Code
Summary by CodeRabbit