Improve pull request prompt and generation handling#800
Improve pull request prompt and generation handling#800gsxdsm merged 2 commits intoAutoMaker-Org:v0.15.0rcfrom
Conversation
Summary of ChangesHello @gsxdsm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the automated generation of pull request descriptions and commit messages by introducing explicit rules to disregard gitignored files and concentrate on meaningful code changes. Concurrently, it enhances the user interface of the pull request creation dialog, making it more responsive and user-friendly, especially when dealing with extensive content. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughUpdated documentation rules to exclude git-ignored files from PR descriptions and commit-message prompts; small UI changes to the PR creation dialog add flex layout, enable scrolling for overflow, and adjust footer spacing. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request improves the prompts for generating pull request descriptions and commit messages by instructing the AI to ignore gitignored and irrelevant files. It also refactors the "Create PR" dialog to better handle long content by making the main area scrollable.
The prompt updates are a good improvement. I've suggested a small refinement in generate-pr-description.ts to combine the new rules for better consistency and conciseness, similar to the change made in defaults.ts.
The UI changes in the CreatePRDialog are well-implemented and correctly use flexbox properties to create a robust and scrollable layout.
Overall, these are solid improvements.
| - EXCLUDE any files that are gitignored (e.g., node_modules, dist, build, .env files, lock files, generated files, binary artifacts, coverage reports, cache directories). These should not be mentioned in the description even if they appear in the diff | ||
| - Focus only on meaningful source code changes that are tracked by git and relevant to reviewers`; |
There was a problem hiding this comment.
For consistency with the changes in libs/prompts/src/defaults.ts, consider combining these two rules into a single, more concise instruction. This also improves prompt efficiency.
For example:
- Ignore changes to gitignored files (e.g., node_modules, dist, build, .env files, lock files, generated files, binary artifacts, coverage reports, cache directories). Focus only on meaningful source code changes that are tracked by git and relevant to reviewers.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/ui/src/components/views/board-view/dialogs/create-pr-dialog.tsx`:
- Line 742: The DialogFooter's className uses the removed Tailwind v4 utility
"flex-shrink-0" which produces no styles; change that class to "shrink-0" in the
DialogFooter component (look for DialogFooter className="flex-shrink-0 pt-2
border-t") so the footer will not shrink unexpectedly under Tailwind v4.1.18 and
tailwind-merge@3.4.0.
apps/ui/src/components/views/board-view/dialogs/create-pr-dialog.tsx
Outdated
Show resolved
Hide resolved
…og.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* Changes from fix/improve-pull-request-prompt * Update apps/ui/src/components/views/board-view/dialogs/create-pr-dialog.tsx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Summary
Summary by CodeRabbit