Skip to content

working on improving the app spec page#94

Merged
webdevcody merged 2 commits intomainfrom
app_spec_fixes
Dec 14, 2025
Merged

working on improving the app spec page#94
webdevcody merged 2 commits intomainfrom
app_spec_fixes

Conversation

@webdevcody
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @webdevcody, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the application's specification (spec) page and its underlying processes. It introduces greater control over spec generation by allowing users to specify whether to analyze their existing codebase or automatically generate features. The user interface for Kanban cards has been upgraded to visually represent feature priorities and dynamically arrange status badges. Additionally, the backend architecture for spec regeneration has been modularized, improving maintainability and introducing a new logging system. These changes collectively aim to provide a more intuitive and robust experience for defining and managing project specifications.

Highlights

  • Enhanced Spec Generation Options: The spec creation and regeneration processes now include options to analyze the current project for context and to automatically generate a feature list after the spec is created.
  • Improved Kanban Card Display: Kanban cards now display feature priority with color-coded badges, and the positioning of all badges (priority, skip tests, error, just finished, branch) has been made dynamic to prevent overlap.
  • Persistent Workspace Directory: The 'New Project' modal now remembers and pre-fills the last used workspace directory, improving user experience for frequent project creation.
  • Priority-Based Backlog Sorting: Features in the backlog are now automatically sorted by priority, allowing users to quickly identify and address high-priority tasks.
  • Modular Backend for Spec Regeneration: The backend logic for spec regeneration has been significantly refactored into smaller, more maintainable modules, and a new logger utility has been introduced for better debugging and monitoring.
  • Updated README and Run Instructions: The README has been substantially updated to provide a clearer overview of Automaker, its workflow, and simplified instructions for running the application.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant and valuable refactoring of the server-side spec regeneration logic, breaking it down into more manageable and modular components. The addition of a dedicated logger and the init.sh script are great improvements for maintainability and developer experience. The UI/UX enhancements on the spec page, including better state management and new generation options, are also well-executed. I've found one high-severity issue in the new server code where a streamed response from the agent is not being handled correctly, which could lead to incomplete data. Please see the specific comment for details.

if (msg.type === "assistant" && msg.message.content) {
for (const block of msg.message.content) {
if (block.type === "text") {
responseText = block.text;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There seems to be a potential bug here. responseText is being overwritten with each new text block from the stream, instead of being concatenated. If the JSON response from the agent is streamed in multiple chunks, this will result in an incomplete JSON string, capturing only the last part of the response. This is inconsistent with the fix applied in auto-mode-service.ts and the logic in generate-spec.ts.

It should be responseText += block.text; to accumulate the full response.

Suggested change
responseText = block.text;
responseText += block.text;

for (const block of msg.message.content) {
if (block.type === "text") {
responseText = block.text || "";
responseText += block.text || "";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a great fix! Overwriting responseText in a streaming context is a common bug, and changing it to += correctly accumulates the full response from the agent. This will prevent issues with incomplete or malformed data.

- Removed the old spec regeneration routes and replaced them with a new structure under the app-spec directory for better modularity.
- Introduced unit tests for common functionalities in app-spec, covering state management and error handling.
- Added documentation on route organization patterns to improve maintainability and clarity for future development.
@webdevcody webdevcody merged commit cdc8334 into main Dec 14, 2025
3 checks passed
@webdevcody webdevcody deleted the app_spec_fixes branch December 14, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant