Skip to content

fix: aligned random pooler input arguments with those of grid pooler#15

Merged
musslick merged 3 commits intomainfrom
fix/random-pooler-input
Jul 6, 2023
Merged

fix: aligned random pooler input arguments with those of grid pooler#15
musslick merged 3 commits intomainfrom
fix/random-pooler-input

Conversation

@musslick
Copy link
Copy Markdown
Contributor

@musslick musslick commented Jul 3, 2023

Description

The PR fixes #13 and #9. It aligns the input arguments from the random pooler and the grid pooler.

Type of change

Delete as appropriate:

  • fix: A bug fix

Features (Optional)

  • fixed input arguments
  • added test for random pooler

@musslick musslick added the enhancement New feature or request. label Jul 3, 2023
@musslick musslick self-assigned this Jul 3, 2023
@musslick musslick requested a review from benwandrew July 3, 2023 22:02
Copy link
Copy Markdown

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Copy Markdown
Contributor

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@musslick musslick added this pull request to the merge queue Jul 6, 2023
Merged via the queue into main with commit 31d60d9 Jul 6, 2023
hollandjg added a commit that referenced this pull request Nov 29, 2023
…s-of-workflow-need-to-be-renamed-form-observationsdvsivs-to-observationsconditionsobservations

refactor: rename from observations.dvs/ivs to data.conditions/observations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

input argument of random pooler should be changed from n to num_samples to conform with the other experimentalists

3 participants