Add doctest to new standard#46
Merged
younesStrittmatter merged 6 commits intomainfrom Sep 8, 2023
Merged
Conversation
younesStrittmatter
requested review from
TheLemonPig,
benwandrew,
chadcwilliams,
hollandjg and
musslick
benwandrew
requested changes
Sep 7, 2023
Co-authored-by: Ben Andrew <benwallaceandrew@gmail.com>
benwandrew
approved these changes
Sep 8, 2023
Contributor
benwandrew
left a comment
benwandrew
left a comment
There was a problem hiding this comment.
crushing it per usual @younesStrittmatter!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add doctests to UserDict state. Add alias functionality as in the old one and converter functionality as in the old one.
Questions
alias and converter functionality are "nice to have" but not 100% necessary in my oppinion. What do you think?