refactor!: make dataclass back into standard state#62
Merged
Conversation
hollandjg
added
bug
hollandjg
changed the title
…ss-as-default # Conflicts: # tests/test_state.py
hollandjg
requested review from
TheLemonPig,
benwandrew,
chadcwilliams,
musslick,
whyhardt and
younesStrittmatter
younesStrittmatter
approved these changes
Nov 30, 2023
younesStrittmatter
left a comment
younesStrittmatter
left a comment
There was a problem hiding this comment.
I thought we would just make the aliases State = StateDataclass and StandardState = StandardStateDataclass, but I am happy with this too. If we need the Dict along the line, we can still use the implementations from previous commits and shouldn't make things more complicated than necessary by having two implementations.
benwandrew
approved these changes
Dec 1, 2023
Contributor
benwandrew
left a comment
benwandrew
left a comment
There was a problem hiding this comment.
so far as i can tell, looks like you caught everything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert State to be defined as a Dataclass rather than a userdict.
Type of change
If this is a breaking change (which might apply to any of the other kinds of change), note that below, otherwise delete
this section:
Features (Optional)