Skip to content

refactor!: remove aliases from state#63

Merged
hollandjg merged 8 commits intomainfrom
chore/remove-aliases-from-state
Dec 1, 2023
Merged

refactor!: remove aliases from state#63
hollandjg merged 8 commits intomainfrom
chore/remove-aliases-from-state

Conversation

@hollandjg
Copy link
Copy Markdown
Member

@hollandjg hollandjg commented Nov 30, 2023

Description

Remove the alias functionality from the State.
Removes standard_state.model –> use standard_state.models[-1] for this case

Type of change

  • refactor: A code change that neither fixes a bug nor adds a feature

@hollandjg hollandjg changed the base branch from main to chore/set-state-dataclass-as-default November 30, 2023 20:49
@hollandjg hollandjg self-assigned this Nov 30, 2023
@hollandjg hollandjg marked this pull request as ready for review November 30, 2023 22:47
@hollandjg hollandjg added bug Something isn't working. priority 0 - emergency These can be blockers, or security issues, and should be resolved immediately. labels Nov 30, 2023
Copy link
Copy Markdown

@younesStrittmatter younesStrittmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks god to me.

Copy link
Copy Markdown
Contributor

@benwandrew benwandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Base automatically changed from chore/set-state-dataclass-as-default to main December 1, 2023 21:39
@hollandjg hollandjg added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 66d03e8 Dec 1, 2023
@hollandjg hollandjg deleted the chore/remove-aliases-from-state branch December 1, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working. priority 0 - emergency These can be blockers, or security issues, and should be resolved immediately.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: remove aliases from state.py

3 participants