Better error messages (develop) #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertgoss
approved these changes
Apr 14, 2021
Collaborator
robertgoss
left a comment
robertgoss
left a comment
There was a problem hiding this comment.
This looks like an improvement to me that would allow better and more flexible error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACT-generated bindings don't contain a mapping between error codes and human-readable names and descriptions. If exception text gets printed this can result in very unfriendly error messages for developers and (if a crash escapes into the wild) users.
This PR adds methods to the binding exception class to get the more human-friendly error name and description specified in the IDL file. The
what()method is reworked to give a default error text with the error name and description, not the number code.