Skip to content

Fix codacy issue in cpp binding. #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexanderoster merged 3 commits into from
Aug 10, 2021
Merged

Fix codacy issue in cpp binding. #161

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66a0ec8
Fix codacy issue in cpp binding.
zpgit Jul 14, 2021
05086dd
Merge branch 'develop' into zpgit/fixcodacy
alexanderoster Aug 10, 2021
2df7480
Merge branch 'develop' into zpgit/fixcodacy
alexanderoster Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Source/buildbindingccpp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ func buildDynamicCLoadTableCode(component ComponentDefinition, w LanguageWriter,

w.Writeln("#ifdef _WIN32")
w.Writeln("// Convert filename to UTF16-string")
w.Writeln("int nLength = (int)strlen(pLibraryFileName);")
w.Writeln("int nLength = static_cast<int>(strnlen_s(pLibraryFileName, MAX_PATH));")
w.Writeln("int nBufferSize = nLength * 2 + 2;")
if (!useStrictC) {
w.Writeln("std::vector<wchar_t> wsLibraryFileName(nBufferSize);")
Expand Down Expand Up @@ -965,7 +965,7 @@ func writeCPPInputVector(w LanguageWriter, NameSpace string, ClassIdentifier str
w.Writeln(" ")
w.Writeln("public:")
w.Writeln(" ")
w.Writeln(" C%sInputVector( const std::vector<T>& vec)", ClassIdentifier)
w.Writeln(" explicit C%sInputVector( const std::vector<T>& vec)", ClassIdentifier)
w.Writeln(" : m_data( vec.data() ), m_size( vec.size() )")
w.Writeln(" {")
w.Writeln(" }")
Expand Down Expand Up @@ -1271,7 +1271,7 @@ func buildCppHeader(component ComponentDefinition, w LanguageWriter, NameSpace s
w.Writeln(" ")

if ExplicitLinking {
w.Writeln(" %s%sWrapper(void* pSymbolLookupMethod)", cppClassPrefix, ClassIdentifier)
w.Writeln(" explicit %s%sWrapper(void* pSymbolLookupMethod)", cppClassPrefix, ClassIdentifier)
w.Writeln(" {")
w.Writeln(" CheckError(nullptr, initWrapperTable(&m_WrapperTable));")
w.Writeln(" CheckError(nullptr, loadWrapperTableFromSymbolLookupMethod(&m_WrapperTable, pSymbolLookupMethod));")
Expand All @@ -1280,7 +1280,7 @@ func buildCppHeader(component ComponentDefinition, w LanguageWriter, NameSpace s
w.Writeln(" }")
w.Writeln(" ")

w.Writeln(" %s%sWrapper(const std::string &sFileName)", cppClassPrefix, ClassIdentifier)
w.Writeln(" explicit %s%sWrapper(const std::string &sFileName)", cppClassPrefix, ClassIdentifier)
w.Writeln(" {")
w.Writeln(" CheckError(nullptr, initWrapperTable(&m_WrapperTable));")
w.Writeln(" CheckError(nullptr, loadWrapperTable(&m_WrapperTable, sFileName.c_str()));")
Expand Down