Use specific class type instead of BaseClassName in ParameterCache template generation #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate generation The buildOutCacheTemplateParameters function was incorrectly using BaseClassName (e.g., "Base") for ALL class output parameters when building the ParameterCache template type. This meant that methods like GeolocationList::GetAt that return specific types like IGeolocation* were being cached as IBase* instead. When a method signature expects IGeolocation*& (reference to IGeolocation pointer) but the cache uses IBase* in its template, the compiler error occurs because: IBase*& and IGeolocation*& are incompatible types References to pointers cannot be implicitly converted, even with inheritance
gangatp
reviewed
Nov 10, 2025
| hasError = iter2->GetNextOptinalAnimal(optionalAnimal); | ||
| assert(hasError == true); | ||
| assert(optionalAnimal != nullptr); | ||
| std::cout << " Got animal: " << optionalAnimal->Name() << std::endl; |
Collaborator
There was a problem hiding this comment.
previously calling optionalAnimal->Name() was not possible, because Base was returned?
gangatp
previously approved these changes
Nov 10, 2025
Collaborator
gangatp
left a comment
gangatp
left a comment
There was a problem hiding this comment.
thanks for adding examples.
Co-authored-by: Paul Davies <40460850+paul-davies-autodesk@users.noreply.github.com>
gangatp
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildOutCacheTemplateParameters function was incorrectly using BaseClassName (e.g., "Base") for ALL class output parameters when building the ParameterCache template type. This meant that methods like GeolocationList::GetAt that return specific types like IGeolocation* were being cached as IBase* instead.
When a method signature expects IGeolocation*& (reference to IGeolocation pointer) but the cache uses IBase* in its template, the compiler error occurs because: IBase*& and IGeolocation*& are incompatible types
References to pointers cannot be implicitly converted, even with inheritance