Property Class Integration Tests #33

sankalps0549 · 2025-11-13T15:08:46Z

Description

This PR introduces the integration tests for the Property class.

Changes in this PR:

Updated data folder with material_property_data and custom_property_data file
Added data generation methods for material_property and custom_property
Added test_integration_property.py
Updated child_markers.json file
Introduced constants for property tests
Updated pytest markers with prop and its children material_property and custom_property
Added property pytest marker to the test_unit_property.py class

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update

Checklist

Please delete options that are not relevant.

I have read the CONTRIBUTING document
My code follows the style guidelines of this project
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have updated the documentation accordingly
I have added a note to CHANGELOG.md describing my changes
My changes generate no new warnings
Any dependent changes have been merged and published

Testing

Added Integration Tests for the Property class

For all property class tests:

python run.py test -m prop

To run tests only on the default material property in Synergy:

python run.py test -m material_property

To run tests on a new custom property created for testing:

python run.py test -m custom_property

Test Data Generation

Parent `prop`

python run.py generate-test-data prop

Child `material_property`

python run.py generate-test-data material_property

Child `custom_property`

python run.py generate-test-data custom_property

Test Run:

Additional Notes

N/A

Copilot

Pull Request Overview

This PR introduces comprehensive integration tests for the Property class, covering both pre-existing material properties and custom properties. The implementation includes test data generation utilities, new test markers for organizing property-related tests, and validation of property metadata, field operations, and field lifecycle management.

Key Changes:

Added integration test suite with 14 test methods covering property initialization, metadata validation, field operations (create, update, hide, delete), and multi-field scenarios
Implemented data generation methods that create JSON test fixtures for material and custom properties
Introduced hierarchical pytest markers (prop, material_property, custom_property) for flexible test execution

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/api/integration_tests/test_integration_property.py	New integration test file with test classes for material and custom properties
tests/api/integration_tests/data/data_generation/generate_data.py	Added data generation methods for material and custom property test fixtures
tests/api/integration_tests/data/material_property_data.json	New JSON fixture containing material property test data
tests/api/integration_tests/data/custom_property_data.json	New JSON fixture containing custom property test data
tests/api/integration_tests/data/metadata.json	Added metadata entries for new test data files
tests/api/integration_tests/constants.py	Added constants for property tests including material database types and field properties
pytest.ini	Registered new pytest markers for property tests
child_markers.json	Defined marker hierarchy for property test organization
tests/api/unit_tests/test_unit_property.py	Added `prop` marker to existing unit test class

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/api/integration_tests/test_integration_property.py

…property-tests

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/api/integration_tests/data/data_generation/generate_data.py

tests/api/integration_tests/constants.py

…-api into property-tests

Copilot

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/api/integration_tests/data/set_fields.py

tests/api/integration_tests/data/data_generation/generate_data.py

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/api/integration_tests/test_integration_property.py

tests/api/integration_tests/data/set_fields.py

tests/api/integration_tests/test_integration_property.py

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/api/integration_tests/data/data_generation/generate_data.py

tests/api/integration_tests/test_integration_property.py

* VectorArray Integration Tests * Bracket fixes * Add SPDX header * Removed read only tag * Vector Class Integration Tests (#6) * Vector Class Integration Tests * Review Fixes * Fixes * Brackets fix * Adding SPDX header * Type order fix * StringArray Class Integration Tests (#11) * StringArray Class Tests * to_list function fix * add spdx headers * IntegerArray Class Integration Tests (#10) * IntegerArray Class Integration Tests * Docstring fixes * Review comments fixes * Add SPDX Header * DoubleArray Class Integration Tests (#9) * DoubleArray Class Integration Tests * Updating unit test * Add SPDX Header * ImportOptions Class Integration Tests (#17) * ImportOptions class integration tests * Marker additions * Code review fixes * MeshSummary Class Integration Tests (#25) * Adding models and model fixtures * MeshSummary Integration Tests * Test Data Generation and Test fixes * README update * README update * Comment fix * Synergy Class Integration Tests (#30) * Adding models and model fixtures * MeshSummary Integration Tests * Test Data Generation and Test fixes * README update * README update * Comment fix * Add non-model based data generation * Synergy Integration Tests * Adding pygetwindow to requirements * Windows size updates and Fixture updates * Copilot review fixes * Zipping study_files * Zip File name changes * Metadata for Test data * Unzip files in test data generation * README updates * Review fixes * Removed ModelType enum * Review fixes * Lint fixes * Project clean up * Revert "Project clean up" This reverts commit 1f16653. * Remove edition assert * CADManager Class Integration Tests (#31) * CADManager Integration Tests * CADManager none tests * Review comment fix * Add Parent-Child Markers, JSON File Name Marker, and Synergy Required Field to Test Data Generation (#32) * Child Markers, Json File Name marker, Synergy in data generation * Review fixes * Review fixes * Property Class Integration Tests (#33) * Property Integration Tests and Child Markers introduction * New Infrastructural changes for the Integration Tests branch (#35) * New Infra * Updating readme, removing childmarkers * Review fix * Timezone added to metadata, docopt command clarification * EntList Integration Tests (#34) * EntList Integration Tests * Update tests/api/integration_tests/test_integration_ent_list.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * SelectFromSavedList function test * Refactoring for new infra * SavedList tests * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * PredicateManager Integration Tests (#38) * PredicateManager Integration Tests * Add marker to unit test * Removing metadata file from integration tests (#55) * Remove metadata from integration tests * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * PropertyEditor Integration Tests (#56) * PropertyEditor Integration Tests * Review fixes * MDLKernel test update --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sankalps0549 added 5 commits November 13, 2025 16:50

Property Integration Tests and Child Markers introduction

a42deca

Child Markers, Json File Name marker, Synergy in data generation

72fff4e

Review fixes

a4f2bda

Review fixes

795ab03

Merge remote-tracking branch 'origin/child-markers' into property-tests

333a11b

sankalps0549 requested a review from Copilot November 13, 2025 15:08

sankalps0549 self-assigned this Nov 13, 2025

Copilot AI reviewed Nov 13, 2025

View reviewed changes

tests/api/integration_tests/test_integration_property.py Outdated Show resolved Hide resolved

tests/api/integration_tests/test_integration_property.py Outdated Show resolved Hide resolved

sankalps0549 mentioned this pull request Nov 13, 2025

Add Parent-Child Markers, JSON File Name Marker, and Synergy Required Field to Test Data Generation #32

Merged

12 tasks

Renamed file set_options, Moving constants to set_fields file

cb4b224

Base automatically changed from child-markers to feature/integration-tests November 17, 2025 17:46

sankalps0549 and others added 3 commits November 17, 2025 23:18

Merge remote-tracking branch 'origin/feature/integration-tests' into …

d00e473

…property-tests

Review fixes

832f176

Merge branch 'feature/integration-tests' into property-tests

faebdd3

sankalps0549 requested a review from Copilot November 17, 2025 17:57

Copilot AI reviewed Nov 17, 2025

View reviewed changes

tests/api/integration_tests/data/data_generation/generate_data.py Outdated Show resolved Hide resolved

tests/api/integration_tests/constants.py Outdated Show resolved Hide resolved

sankalps0549 added 2 commits November 17, 2025 23:34

import fixes

5b98d8e

Merge branch 'property-tests' of https://github.com/Autodesk/moldflow…

22e743a

…-api into property-tests

sankalps0549 requested a review from Copilot November 17, 2025 18:05

Copilot AI reviewed Nov 17, 2025

View reviewed changes

tests/api/integration_tests/data/set_fields.py Outdated Show resolved Hide resolved

tests/api/integration_tests/data/data_generation/generate_data.py Outdated Show resolved Hide resolved

function cleanup

19566b5

sankalps0549 requested a review from Copilot November 17, 2025 18:32

Copilot AI reviewed Nov 17, 2025

View reviewed changes

tests/api/integration_tests/test_integration_property.py Outdated Show resolved Hide resolved

tests/api/integration_tests/data/set_fields.py Show resolved Hide resolved

tests/api/integration_tests/test_integration_property.py Show resolved Hide resolved

bracket fix

a992db7

sankalps0549 requested a review from Copilot November 17, 2025 18:35

Copilot AI reviewed Nov 17, 2025

View reviewed changes

tests/api/integration_tests/data/data_generation/generate_data.py Show resolved Hide resolved

tests/api/integration_tests/test_integration_property.py Show resolved Hide resolved

sankalps0549 marked this pull request as ready for review November 17, 2025 18:50

sankalps0549 requested review from LiawChungYao and osinjoku November 17, 2025 18:50

osinjoku approved these changes Nov 18, 2025

View reviewed changes

LiawChungYao reviewed Nov 18, 2025

View reviewed changes

tests/api/integration_tests/test_integration_property.py Show resolved Hide resolved

LiawChungYao approved these changes Nov 19, 2025

View reviewed changes

sankalps0549 merged commit 24e8cf5 into feature/integration-tests Nov 19, 2025
19 checks passed

sankalps0549 deleted the property-tests branch November 19, 2025 04:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Property Class Integration Tests #33

Property Class Integration Tests #33

Uh oh!

sankalps0549 commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Property Class Integration Tests #33

Property Class Integration Tests #33

Uh oh!

Conversation

sankalps0549 commented Nov 13, 2025

Description

Changes in this PR:

Type of change

Checklist

Testing

Test Data Generation

Parent prop

Child material_property

Child custom_property

Test Run:

Additional Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Parent `prop`

Child `material_property`

Child `custom_property`