Skip to content

fix: remove propTypes for Column.key #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2020
Merged

fix: remove propTypes for Column.key #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## NEXT VERSION

- fix: remove propTypes for Column.key

## v1.11.2 (2020-08-18)

- fix: add missing types for propTypes of `BaseTable`
Expand Down
4 changes: 0 additions & 4 deletions src/Column.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ export const FrozenDirection = {
class Column extends React.Component {}

Column.propTypes = {
/**
* Unique key for each column
*/
key: PropTypes.oneOfType([PropTypes.string, PropTypes.number]).isRequired,
/**
* Class name for the column cell, could be a callback to return the class name
* The callback is of the shape of `({ cellData, columns, column, columnIndex, rowData, rowIndex }) => string`
Expand Down