feat: add the ability to pass function in estimatedRowHeight #241
Conversation
nihgwu
left a comment
nihgwu
left a comment
There was a problem hiding this comment.
great feature 👍 , this would make detail view more reasonable, thank you.
I didn't do it before as I always think it could be time consuming when calculating the total height, but I think it should be OK for most cases
src/GridTable.js
Outdated
| return ( | ||
| (this.innerRef && this.innerRef.clientHeight) || | ||
| (typeof estimatedRowHeight === 'function' | ||
| ? data.reduce((height, rowData, rowIndex) => height + estimatedRowHeight({ rowData, rowIndex }), 0) |
There was a problem hiding this comment.
I think it would be time consuming with large dataset, maybe we should memoize the calculation, and move to utils to be shared with BaseTable
There was a problem hiding this comment.
I also thought about it, and now I memoized this calculation. But i can't memoize it directly in the utils, because there may be several instances of different tables with different data mounted at same time, so i did it in components.
…mine the initial height of rows
eKazim
force-pushed
the
estimatedRowHeight
branch
from
3566ec8 to
5797fcc
Compare
|
@eKazim Can you show an example of how you memoize it in the component. |
|
@carlospence eKazim meant to memoize in table instead of utils, and here it is https://github.com/Autodesk/react-base-table/pull/241/files#diff-742bc603eb318c857af110e47ad1c65f902e051f7ea70fcb60e52ba48e73ec1fR124 |
3 participants
This PR makes possible to pass in
estimatedRowHeightproperty a function that called for each row to get initial height of row. This can help to fix "jumping" effect on first rendering when height of rows are known (possible fix #227)