Respond to feedback on conditional discount handling in IBS/CBS calculation #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
[WIP] Address feedback on discount details in tax reform implementation
Respond to feedback on conditional discount handling in IBS/CBS calculation
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed review comment questioning whether IBS/CBS base calculation should check discount type before subtracting, similar to PIS/COFINS/ICMS implementations.
Analysis provided
CalculaBaseCalculoPis,CalculaBaseCalculoCofins,CalculaBaseCalculoIcms) checkTipoDescontobefore applying discount:TipoDesconto.Incondicional: subtract from baseTipoDesconto.Condincional: add to base (skip subtraction)Recommendation
Maintain consistency with existing tax calculation patterns by checking
_tipoDescontoparameter before subtracting discount. Can be adjusted if reform-specific documentation emerges.No code changes made pending approval from @robertorp.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.