Remove all try-catch blocks from CalculaBaseCalculoIbsCbs #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback on PR #42 to remove all exception handling from the CalculaBaseCalculoIbsCbs class.
Changes
CalcularValorPis()CalcularValorCofins()CalcularValorIcms()CalcularValorIssqn()using System;directive (no longer needed)This is a breaking behavioral change. Previously, these methods would silently return
0on any exception. Now, any exceptions from the calculation methods will propagate to calling code, allowing proper error handling at a higher level in the application.Testing
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.