Bellatrix Jira Zephyr Plugin #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added TestDurationWatcher and TimeRecord for tests
n1xan
reviewed
Jun 5, 2024
| public void postBeforeTest(TestResult testResult, Method memberInfo) { | ||
| } | ||
|
|
||
|
|
n1xan
reviewed
Jun 5, 2024
| package solutions.bellatrix.core.plugins; | ||
|
|
||
| import org.apache.http.annotation.Obsolete; | ||
|
|
n1xan
reviewed
Jun 5, 2024
| } | ||
| } | ||
|
|
||
|
|
n1xan
reviewed
Jun 5, 2024
| } | ||
|
|
||
| private String getProjectId(Method memberInfo) { | ||
| if (memberInfo.getDeclaringClass().isAnnotationPresent(ZephyrProject.class)) { |
Collaborator
There was a problem hiding this comment.
do we support the attribute only on the class level?
n1xan
reviewed
Jun 5, 2024
| try { | ||
| return settings().getDefaultProjectKey(); | ||
| } catch (Exception ex) { | ||
| return ""; |
Collaborator
There was a problem hiding this comment.
add error log - Zephyr Project Id annotation not found on class level
Collaborator
There was a problem hiding this comment.
actually it is reading it from the config
n1xan
reviewed
Jun 5, 2024
|
|
||
| var testCycleName = String.format("%s %s", | ||
| DateTimeUtilities.getUtcNow(), | ||
| settings().getTestCycleName().isBlank() ? settings().getTestCycleName() : "BELLATRIX RUN"); |
Collaborator
There was a problem hiding this comment.
this is fine for now, but potentially we would want to set this via Environment variable.
n1xan
reviewed
Jun 5, 2024
| DateTimeUtilities.getUtcNow(), | ||
| settings().getTestCycleName().isBlank() ? settings().getTestCycleName() : "BELLATRIX RUN"); | ||
|
|
||
| var testCycle = new ZephyrTestCycle(settings().getDefaultProjectKey(), testCycleName, "In Progress"); |
Collaborator
There was a problem hiding this comment.
maybe extract the statuses to enum?
n1xan
reviewed
Jun 5, 2024
| public static final EventListener<ZephyrExecutionPluginEventArgs> ZEPHYR_TEST_CASE_EXECUTED = new EventListener<>(); | ||
| public static final EventListener<ZephyrCyclePluginEventArgs> ZEPHYR_CYCLE_STATUS_UPDATE_FAILED = new EventListener<>(); | ||
|
|
||
| private ZephyrLocalData data; |
Collaborator
There was a problem hiding this comment.
this is a bit generic - I would rename it to zaphyrData
n1xan
reviewed
Jun 5, 2024
| } | ||
| } | ||
|
|
||
| @Getter @Setter |
Collaborator
There was a problem hiding this comment.
a class in the class? We usually create them in separate files
n1xan
previously requested changes
Jun 5, 2024
Collaborator
n1xan
left a comment
n1xan
left a comment
There was a problem hiding this comment.
Please review and fix the PR comments.
teo-nikolov
approved these changes
Jul 9, 2024
# Conflicts: # bellatrix.core/src/main/java/solutions/bellatrix/core/plugins/PluginExecutionEngine.java # bellatrix.core/src/main/java/solutions/bellatrix/core/plugins/junit/BaseTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.