[Nullability Annotations to Java Classes] Add wordpress.lint Dependency#196
[Nullability Annotations to Java Classes] Add wordpress.lint Dependency#196
wordpress.lint Dependency#196Conversation
Release Notes: https://github.com/wordpress-mobile/ WordPress-Lint-Android/releases/tag/2.0.0
| url "https://a8c-libs.s3.amazonaws.com/android" | ||
| content { | ||
| includeGroup "org.wordpress" | ||
| includeGroup "org.wordpress.lint" |
There was a problem hiding this comment.
| includeGroup "org.wordpress.lint" |
The group for lint library is org.wordpress - there's no need to add the other group (which is not valid AFAIK, lint is the name of a module)
There was a problem hiding this comment.
Also to make the example module work on the Catalog repo, I added this line there too, following the Adding a new dependency documentation, as I was indeed hitting a problem on it... 🤷
Build the catalog & example projects - if you get Could not find {dependency} error, make sure the repository for the new dependency you've added is included in example/settings.gradle.kts
There was a problem hiding this comment.
Yeap, I wasn't 100% sure about adding org.wordpress.lint too, I just followed the same pattern across all of our other repos, see this Login repo as an example... 🤷
It seems that this part in Login is also incorrect - it adds a valid group org.wordpress but also invalid and unnecessary one: org.wordpress.fluxc.
Also to make the example module work on the Catalog repo, I added this line there too, following the Adding a new dependency documentation, as I was indeed hitting a problem on it... 🤷
Yes, this line is correct - it adds a new module (not group) so it specifies lint module with it's group: org.wordpress.
Related PR Comment: https://github.com/Automattic/ Automattic-Tracks-Android/pull/196#discussion_r1371514709
This PR adds
wordPress-lintchecks to the project (2.0.0).To test:
MissingNullAnnotationOn*correctness related rules are reporting as expected. For a reference, see screenshot below: