Skip to content

[Lib] Update targetSdk from 33 to 34.#200

Merged
ravishanker merged 2 commits intotrunkfrom
andy/issue-20360
Mar 26, 2024
Merged

[Lib] Update targetSdk from 33 to 34.#200
ravishanker merged 2 commits intotrunkfrom
andy/issue-20360

Conversation

@notandyvee
Copy link
Copy Markdown
Contributor

@notandyvee notandyvee commented Mar 1, 2024

Issue: #199

What

This PR updates the targetSdk from 33 to 34. This is in preparation for the Android 14 update.

Test

@notandyvee notandyvee added the Core label Mar 1, 2024
@notandyvee notandyvee requested a review from ravishanker March 1, 2024 22:09
@wzieba
Copy link
Copy Markdown
Member

wzieba commented Mar 5, 2024

hi @ravishanker @notandyvee 👋 WDYT about merging this PR soon?

After this PR, I'd also like to merge #201 and then release new version of the Tracks, 3.4.1. Would that work for you?

@notandyvee
Copy link
Copy Markdown
Contributor Author

@irfano I added you in the event Ravi doesn't have time to review. I updated the wp-android test branch so you can test an apk directly.

Copy link
Copy Markdown
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ravishanker ravishanker merged commit c4ca5e6 into trunk Mar 26, 2024
@ravishanker ravishanker deleted the andy/issue-20360 branch March 26, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants