fix: do not track failed http requests#205
Merged
malinajirka merged 1 commit intotrunkfrom Mar 21, 2024
Merged
Conversation
wzieba
force-pushed
the
do_not_track_failed_requests
branch
from
20fc761 to
53a65bb
Compare
wzieba
force-pushed
the
do_not_track_failed_requests
branch
from
53a65bb to
4ef829e
Compare
Member
Author
|
hi @malinajirka 👋 are you fine with reviewing this PR? No need for testing, it's just a configuration change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After bump of Sentry SDK to 7.x version, in WooCommerce Android we started to observe issues with thrown
SentryHttpClientException. Internal context: p1710951263665769-slack-C6H8C3G23The reason is that, it seems by a mistake, Sentry SDK in version
7.5.0enabledcaptureFailedRequestsfeature by default, while it was disabled by default in previously used by us,6.32.0.I say "by a mistake" because the comment above the code in
7.5.0states thatcaptureFailedRequestsshould be disabled by default.6.32.0
https://github.com/getsentry/sentry-java/blob/a57bf6f1cdaf5840c6761c2946723804055a79c3/sentry-android-okhttp/src/main/java/io/sentry/android/okhttp/SentryOkHttpInterceptor.kt#L42
7.5.0
https://github.com/getsentry/sentry-java/blob/c2b79e4ef6bc7a32dc5fd83c980a547b87e5498b/sentry-android-okhttp/src/main/java/io/sentry/android/okhttp/SentryOkHttpInterceptor.kt#L36