ExPlat: remove "unknown" variation, handle null and not-returned cases#167
Merged
leandroalonso merged 3 commits intodevelopfrom Jan 20, 2021
Merged
Conversation
…riment is null or not present
withinboredom
approved these changes
Jan 20, 2021
withinboredom
left a comment
There was a problem hiding this comment.
LGTM, but might want to also remove other as well, and just have treatment accept a name for the treatment.
| @@ -4,7 +4,6 @@ public enum Variation: Equatable { | |||
| case control | |||
| case treatment | |||
| case other(String) | |||
There was a problem hiding this comment.
It might be a good idea to do what @renanferrari did on wordpress-mobile/WordPress-FluxC-Android#1845 -- and make Treatment take a string since other() is just a different Treatment (for when we support multi-variate experiments).
Member
Author
|
@jkmassel I have a totally unrelated Mac OS X test failing here ( Running it again doesn't seem to solve (and the test works just fine in my machine™️), any idea how to proceed? Edit: of course now it worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements some changes in the AB testing feature based on @withinboredom comments in a previous PR:
unknownvariation. The default fallback iscontrolnullvalue in the JSON, treat it ascontrolcontrolother()variation. All variations are effectively a treatment variation, the API was slightly changed:How to test
Code review and green CI should be enough. :)