PHP 8.2 support: Add AllowDynamicProperties attribute#164
Merged
Conversation
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0. Reference: [https://wiki.php.net/rfc/deprecate_dynamic_properties PHP RFC: Deprecate dynamic properties]. This resolves the following deprecation warnings: Deprecated: Creation of dynamic property hyperdb::$callback_result is deprecated Deprecated: Creation of dynamic property hyperdb::$current_host is deprecated Deprecated: Creation of dynamic property hyperdb::$dataset is deprecated Deprecated: Creation of dynamic property hyperdb::$dbhname is deprecated Deprecated: Creation of dynamic property hyperdb::$lag is deprecated Deprecated: Creation of dynamic property hyperdb::$lag_cache_key is deprecated Deprecated: Creation of dynamic property hyperdb::$lag_threshold is deprecated Deprecated: Creation of dynamic property hyperdb::$last_connection is deprecated Deprecated: Creation of dynamic property hyperdb::$last_errno is deprecated Deprecated: Creation of dynamic property hyperdb::$table is deprecated
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.
Reference: PHP RFC: Deprecate dynamic properties.
This PR resolves the following deprecation warnings:
It applies a similar fix as used by the WordPress core:
https://github.com/WordPress/WordPress/blob/master/wp-includes/class-wp-user.php#L41-L42
#[AllowDynamicProperties] class WP_User {