Replace the use of isEnabled() to isHittable()#12
Merged
Conversation
This was referenced Sep 6, 2022
pachlava
approved these changes
Sep 6, 2022
Contributor
pachlava
left a comment
pachlava
left a comment
There was a problem hiding this comment.
The nature of this change is such, that I feel comfortable approving the PR just after seeing the linked WPiOS / WCiOS PRs pass. Also, using isHittable sounds more natural than isEnabled here. Thank you for working on this @jostnes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
To replace the use of
isEnabled()withisHittable(), also thought of adding both but after testing found that that is unnecessaryWhy the change?
It was reported in woocommerce/woocommerce-ios#7526 that
.isLoaded()method which uses thiswaitForScreenfrom ScreenObject could result in a false positive if the element still exists behind a modal. By updating this toisHittableit will no longer work if the element is behind a modal.Testing
Test repos that are using this and make sure that all UI Tests still work - WCiOS and WPiOS.