Skip to content

Adding open attribute ending with url to the ProperEscapingFunction sniff #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-binda merged 1 commit into from
Nov 30, 2017
Merged

Adding open attribute ending with url to the ProperEscapingFunction sniff #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPressVIPMinimum/Sniffs/VIP/ProperEscapingFunctionSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public function process( File $phpcsFile, $stackPtr ) {
*/
public function is_href_or_src( $content ) {
$is_href_or_src = false;
foreach ( array( 'href', 'src' ) as $attr ) {
foreach ( array( 'href', 'src', 'url' ) as $attr ) {
foreach ( array(
'="',
"='",
Expand Down
10 changes: 10 additions & 0 deletions WordPressVIPMinimum/Tests/VIP/ProperEscapingFunctionUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,13 @@ echo "<a title='" . esc_html( $some_var ) . "'></a>"; // NOK.
<a href="<?php esc_url( $url );?>"></a> <!-- OK. -->

<a title="<?php esc_attr( $url );?>"></a> <!-- OK. -->

<?php

echo '<media:content url="' . esc_url( $post_image ) . '" medium="image">'; // OK.

echo '<media:content url="' . esc_attr( $post_image ) . '" medium="image">'; // NOK.

echo 'data-param-url="' . esc_url( $share_url ) . '"'; // OK.

echo 'data-param-url="' . esc_html( $share_url ) . '"'; // NOK.
2 changes: 2 additions & 0 deletions WordPressVIPMinimum/Tests/VIP/ProperEscapingFunctionUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ public function getErrorList() {
17 => 1,
21 => 1,
23 => 1,
33 => 1,
37 => 1,
);
}

Expand Down