Decompose animated marketing sections into native blocks instead of core/html app-shell fallback#491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ordinary marketing
<section>s were preserved wholesale as a singlecore/htmlblock whenever animation/counter scripts targeted elements inside them.shouldPreserveRuntimeAppShell()counted presentation-only selectors (.reveal,[data-count], animate/motion/scroll classes) fed byArtifactCompiler::runtimeDomSelectors()as runtime app-shell evidence, so any section with scroll-reveal animation looked like an interactive app and fell back — the single largest fallback family in the Static Site Importer fixture matrix (12 findings across 4 fixtures on the complexity-1 lane).Fix
isRuntimeDomTarget()and data-attribute preservation — generalizing the existing data-animation filter to class/id/data selectors. Structural decision only; no fixture- or class-name-specific matching beyond generic animation vocabulary.data-countsupport indynamicTextContent()so counter text stays editable.html-section-runtime-animation-native-decomposition.json.Verification
composer test(canonical + 203 parity fixtures + packaging).wp.blocks.validateBlock):fallback_block:core_html_block:sectionfamily: 12 → 0AI assistance