Skip to content

Conversation

@phess101
Copy link

Description

Currently, if you try to create a new Table with no options, you will get a crashing error. We need to first do a null check against options.

Checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change has relevant unit tests.
  • This change has relevant documentation additions / updates (if applicable).

Deploy Notes

Notes regarding deployment of this PR, if any.

Steps to Test or Reproduce

  1. Create an instance of Table without any options
  2. Verify that your table object is not null, and there were no exceptions thrown

@phess101
Copy link
Author

Related to issue #153

@yjhuoh
Copy link

yjhuoh commented Nov 17, 2021

ha looks like we did the same thing. #155

@clintecker
Copy link

👍

@clintecker
Copy link

This is currently breaking Google's firebase-tools as their dependency is specified as ^0.3.1 :(

@yjhuoh
Copy link

yjhuoh commented Nov 17, 2021

😆 that's exactly how we discovered it

@clintecker
Copy link

I've emailed @chrean, but maybe @igoradamenko or @msabramo could help us out

@yjhuoh
Copy link

yjhuoh commented Nov 17, 2021

maybe we should just pin the version in firebase-tools 🤔

@mikeendale
Copy link

+1 Please merge

maybe we should just pin the version in firebase-tools 🤔

Created a PR for that too: firebase/firebase-tools#3908

@chrean chrean merged commit cebaac2 into Automattic:master Nov 18, 2021
@chrean chrean mentioned this pull request Nov 23, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants