Skip to content

handle undefined options #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

handle undefined options #155

wants to merge 1 commit into from

Conversation

@yjhuoh
Copy link

@yjhuoh yjhuoh commented Nov 17, 2021 •
edited
Loading

Description

unhandled undefined options was causing errors

Checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change has relevant unit tests.
  • This change has relevant documentation additions / updates (if applicable).

Deploy Notes

Notes regarding deployment of this PR, if any.

Steps to Test or Reproduce

  1. npm run test

@yjhuoh yjhuoh mentioned this pull request Nov 17, 2021
Merged
3 tasks
@chrean
Copy link
Contributor

chrean commented Nov 23, 2021

I think this was fixed via #154 ?

@chrean chrean closed this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yjhuoh @chrean