[codex] Add WP object edit-delete merge smoke coverage#212
Merged
Conversation
cb132a2 to
a8b145e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Adds fast COW merge smoke regressions for two WordPress object graphs where the source branch edits an object while the target branch deletes it:
wp_commentspluswp_commentmetaforkpress_notegraph acrosswp_posts,wp_postmeta,wp_options, andwp_term_relationshipsIt also updates the merge reliability matrix to record the v0.1.28 release gate and the new edit/delete coverage.
Rationale
The smoke suite already covered create/create merges and edit/delete conflicts for reusable blocks, menus, and attachments. Comments and CPT rows are also complete WordPress object graphs. These cases should stay reviewable and preserve the target deletion before review instead of silently resurrecting target-deleted content.
Implementation
The new fixtures assert:
completed_with_conflictsfor source-edit/target-delete graph racesrow-target-deletedconflicttarget-winsuntil a reviewer resolves the conflictTesting instructions