Validate attachment child MIME metadata shape#368
Merged
Conversation
Report empty or non-string generated-size and backup-size MIME metadata through the built-in WordPress upload validator instead of treating malformed values as MIME drift.
adamziel
added a commit
that referenced
this pull request
May 18, 2026
## What it does Adds focused media-validator coverage for generated-size and backup-size `mime-type` metadata values that are present but not strings. ## Rationale PR #368 taught the built-in WordPress upload validator to classify empty or non-string child MIME metadata as `plugin-wp-attachment-metadata-invalid-shape`. The fixture covered empty strings; this adds explicit non-string evidence so the guard cannot regress silently. ## Implementation The fixture now creates one generated child image with numeric `mime-type` metadata and one backup image with numeric `mime-type` metadata. The assertions verify both records appear in the built-in invalid-shape audit, while the built-in MIME-drift conflict count remains unchanged. ## Testing instructions ```bash git diff --check 'origin/trunk'...HEAD && git diff --check && git diff --cached --check php -l tests/cow/media_validator.php php tests/cow/media_validator.php ``` Co-authored-by: Codex <codex@openai.com>
Merged
adamziel
added a commit
that referenced
this pull request
May 18, 2026
## Release `v0.1.44` Version bump and release metadata update for `v0.1.44`. **Changelog draft:** * Validate attachment child MIME metadata shape ([#368](#368)) * Cover non-string attachment child MIME metadata ([#369](#369)) * Cover explicit parent page ID holds ([#370](#370)) * Refresh merge reliability evidence for v0.1.43 ([#371](#371)) **Full changelog:** v0.1.43...release/v0.1.44 ## Next steps 1. **Review** the changes in this pull request. 2. **Push** any additional edits to this branch (`release/v0.1.44`). 3. **Merge** this pull request to publish `v0.1.44`. Merging will automatically build ForkPress binaries, create a GitHub release, and update the Homebrew formula. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Reports present-but-empty or non-string generated-size and backup-size
mime-typemetadata asplugin-wp-attachment-metadata-invalid-shapein the built-in WordPress upload validator.Rationale
Malformed
mime-typefields are metadata shape problems, not extension drift. Keeping them in the invalid-shape bucket avoids presenting bad metadata as a normal MIME mismatch repair.Implementation
cow_merge_wordpress_attachment_upload_issues()now validates generated and backupmime-typevalues before comparing them to the file extension. Invalid values record the affected metadata field, role, value type, attachment file, child file, and upload path evidence.The media validator fixture adds generated-size and backup-size attachments with empty child MIME metadata and asserts that the built-in validator records invalid-shape conflicts while the built-in MIME-drift count stays unchanged.
Testing instructions