[codex] Cover runtime semantic plugin validator#52
Open
adamziel wants to merge 1 commit into
Open
Conversation
5a5d4d8 to
390766b
Compare
c86a2c5 to
fad4abf
Compare
fad4abf to
8eed439
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The semantic E2E already inspected plugin-shaped data after merge, but the product validator path was only covered in PHP unit fixtures. This makes the real runtime path prove that a plugin can validate a coherent graph spanning custom tables, JSON, serialized data, options, postmeta, CPT/page references, and an upload file after a normal branch merge.
This PR is stacked on #49 because current
trunkfails before the semantic section at WP UI nonce extraction. Once #49 lands, this should be retargeted totrunk.Validation
bash -n tests/cow/e2e.shphp -l /dev/stdin{\"status\":\"valid\",\"findings\":[]}git diff --check origin/codex/wp-ui-nonce-e2e-helper..HEAD