Skip to content

feat: do a mistake→make a mistake#2463

Merged
elijah-potter merged 8 commits intoAutomattic:masterfrom
hippietrail:do-a-mistake
Mar 12, 2026
Merged

feat: do a mistake→make a mistake#2463
elijah-potter merged 8 commits intoAutomattic:masterfrom
hippietrail:do-a-mistake

Conversation

@hippietrail
Copy link
Collaborator

@hippietrail hippietrail commented Jan 11, 2026

Issues

N/A

Description

Early work-in-progress for the common nonnative error "do a mistake" instead of "make a mistake".

I also added a helper method followed_by_word for checking the next word in the context and I applied it and a sibling methd preceded_by_word to half a dozen other linters.

How Has This Been Tested?

Unit tests from sentences found on GitHub and other techy websites.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

@hippietrail hippietrail added linting grammar An issue related to higher-level grammar checking labels Feb 22, 2026
@hippietrail hippietrail marked this pull request as ready for review February 22, 2026 08:41
Copy link
Collaborator

@elijah-potter elijah-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Much cleaner as well.

I am sorry it took me so long to review this. I was a bit confused when I saw "wip" in the title. Thanks!

@elijah-potter elijah-potter added this pull request to the merge queue Mar 12, 2026
@hippietrail
Copy link
Collaborator Author

This looks great! Much cleaner as well.

I am sorry it took me so long to review this. I was a bit confused when I saw "wip" in the title. Thanks!

Oh sorry I didn't spot that "wip" still in there - I better check my other PRs too...

@hippietrail hippietrail changed the title feat: wip: do a mistake→make a mistake feat: do a mistake→make a mistake Mar 12, 2026
Merged via the queue into Automattic:master with commit 1c033ca Mar 12, 2026
11 checks passed
@hippietrail hippietrail deleted the do-a-mistake branch March 12, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

grammar An issue related to higher-level grammar checking linting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants