fix(core): stop flagging "Czech Republic" as outdated#2797
Merged
elijah-potter merged 1 commit intoAutomattic:masterfrom Feb 26, 2026
Merged
Conversation
"Czech Republic" is the country's formal name, while "Czechia" is the official short name. Both are valid, similar to "French Republic" vs "France". Remove the mapping and add a regression test.
elijah-potter
approved these changes
Feb 26, 2026
Collaborator
elijah-potter
left a comment
elijah-potter
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for the patch!
In the future, if you're addressing a specific issue #, reference it in the test name. For example, that could look like dont_flag_czech_republic_issue_2692.
It isn't a hard and fast rule, and it's definitely not going to stop me from merging this. Thanks again!
NaveenPrasanth
added a commit
to NaveenPrasanth/harper
that referenced
this pull request
Feb 27, 2026
"esp." is not Latin, so rename the function and constants to "abbreviation" which correctly describes both Latin (etc., vs., et al.) and non-Latin (esp.) abbreviations. Also rename test per review feedback on Automattic#2797.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2692
Czech Republic → Czechiamapping fromUpdatePlaceNamesTest plan
cargo test -p harper-core update_place_names: all 17 tests passcargo fmt: appliedcargo clippy -p harper-core: no new warnings