refactor: two-digit decade support#2911
Merged
elijah-potter merged 19 commits intoAutomattic:masterfrom Mar 12, 2026
Merged
Conversation
…cades-389-two-digit-refactor
…cades-389-two-digit-refactor
elijah-potter
approved these changes
Mar 12, 2026
Collaborator
elijah-potter
left a comment
elijah-potter
left a comment
There was a problem hiding this comment.
Awesome! Great stuff. I'm a fan of all of those tests.
Collaborator
Author
I'm thinking of ways to make tests more data-driven generally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Further work on #389
Description
Adds support for 2-digit decades.
It's extremely common that people always write decades followed by an apostrophe as though the numbers possess something. Correctly, when referring to a decade of someone's life there should be no apostrophe, and when referring to a decade of history, the apostrophe should be before the numbers, representing the elided first two digits:
How Has This Been Tested?
Many unit tests harvested from GitHub. As with the 4-digit support, the linter can't yet discern all the possibilities. So the sentences are still included but
ignored so future devs may continue iterating on the module without having to collect more example sentences.Checklist