fix(core): test which was testing the wrong thing#2946
Merged
elijah-potter merged 1 commit intomasterfrom Mar 16, 2026
Merged
Conversation
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
The problem was caused in #2875.
Description
In #2875, we changed how words were itereated to fix #2861. In doing so, we unknowningly broke a property test, which asserted that any number or word prior to "a" would coerce "a" to lowercase. The linked PR changed this behavior to exclude numbers. This PR addresses that inconcsistence and has the test only use alphabetic characters rather than alphanumeric characters.
How Has This Been Tested?
Fuzzed.
Checklist